Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: src/inspector/V8InspectorImpl.h

Issue 2332243002: [inspector] fixed all deprecated calls (Closed)
Patch Set: addressed comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/inspector/V8InjectedScriptHost.cpp ('k') | src/inspector/V8InspectorImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 39
40 #include <vector> 40 #include <vector>
41 41
42 namespace v8_inspector { 42 namespace v8_inspector {
43 43
44 class InspectedContext; 44 class InspectedContext;
45 class V8ConsoleMessageStorage; 45 class V8ConsoleMessageStorage;
46 class V8Debugger; 46 class V8Debugger;
47 class V8DebuggerAgentImpl; 47 class V8DebuggerAgentImpl;
48 class V8InspectorSessionImpl; 48 class V8InspectorSessionImpl;
49 class V8ProfilerAgentImpl;
49 class V8RuntimeAgentImpl; 50 class V8RuntimeAgentImpl;
50 class V8StackTraceImpl; 51 class V8StackTraceImpl;
51 52
52 class V8InspectorImpl : public V8Inspector { 53 class V8InspectorImpl : public V8Inspector {
53 V8_INSPECTOR_DISALLOW_COPY(V8InspectorImpl); 54 V8_INSPECTOR_DISALLOW_COPY(V8InspectorImpl);
54 55
55 public: 56 public:
56 V8InspectorImpl(v8::Isolate*, V8InspectorClient*); 57 V8InspectorImpl(v8::Isolate*, V8InspectorClient*);
57 ~V8InspectorImpl() override; 58 ~V8InspectorImpl() override;
58 59
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
112 bool hasConsoleMessageStorage(int contextGroupId); 113 bool hasConsoleMessageStorage(int contextGroupId);
113 using ContextByIdMap = 114 using ContextByIdMap =
114 protocol::HashMap<int, std::unique_ptr<InspectedContext>>; 115 protocol::HashMap<int, std::unique_ptr<InspectedContext>>;
115 void discardInspectedContext(int contextGroupId, int contextId); 116 void discardInspectedContext(int contextGroupId, int contextId);
116 const ContextByIdMap* contextGroup(int contextGroupId); 117 const ContextByIdMap* contextGroup(int contextGroupId);
117 void disconnect(V8InspectorSessionImpl*); 118 void disconnect(V8InspectorSessionImpl*);
118 V8InspectorSessionImpl* sessionForContextGroup(int contextGroupId); 119 V8InspectorSessionImpl* sessionForContextGroup(int contextGroupId);
119 InspectedContext* getContext(int groupId, int contextId) const; 120 InspectedContext* getContext(int groupId, int contextId) const;
120 V8DebuggerAgentImpl* enabledDebuggerAgentForGroup(int contextGroupId); 121 V8DebuggerAgentImpl* enabledDebuggerAgentForGroup(int contextGroupId);
121 V8RuntimeAgentImpl* enabledRuntimeAgentForGroup(int contextGroupId); 122 V8RuntimeAgentImpl* enabledRuntimeAgentForGroup(int contextGroupId);
123 V8ProfilerAgentImpl* enabledProfilerAgentForGroup(int contextGroupId);
122 124
123 private: 125 private:
124 v8::Isolate* m_isolate; 126 v8::Isolate* m_isolate;
125 V8InspectorClient* m_client; 127 V8InspectorClient* m_client;
126 std::unique_ptr<V8Debugger> m_debugger; 128 std::unique_ptr<V8Debugger> m_debugger;
127 v8::Global<v8::Context> m_regexContext; 129 v8::Global<v8::Context> m_regexContext;
128 int m_capturingStackTracesCount; 130 int m_capturingStackTracesCount;
129 unsigned m_lastExceptionId; 131 unsigned m_lastExceptionId;
130 132
131 using MuteExceptionsMap = protocol::HashMap<int, int>; 133 using MuteExceptionsMap = protocol::HashMap<int, int>;
132 MuteExceptionsMap m_muteExceptionsMap; 134 MuteExceptionsMap m_muteExceptionsMap;
133 135
134 using ContextsByGroupMap = 136 using ContextsByGroupMap =
135 protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>; 137 protocol::HashMap<int, std::unique_ptr<ContextByIdMap>>;
136 ContextsByGroupMap m_contexts; 138 ContextsByGroupMap m_contexts;
137 139
138 using SessionMap = protocol::HashMap<int, V8InspectorSessionImpl*>; 140 using SessionMap = protocol::HashMap<int, V8InspectorSessionImpl*>;
139 SessionMap m_sessions; 141 SessionMap m_sessions;
140 142
141 using ConsoleStorageMap = 143 using ConsoleStorageMap =
142 protocol::HashMap<int, std::unique_ptr<V8ConsoleMessageStorage>>; 144 protocol::HashMap<int, std::unique_ptr<V8ConsoleMessageStorage>>;
143 ConsoleStorageMap m_consoleStorageMap; 145 ConsoleStorageMap m_consoleStorageMap;
144 }; 146 };
145 147
146 } // namespace v8_inspector 148 } // namespace v8_inspector
147 149
148 #endif // V8_INSPECTOR_V8INSPECTORIMPL_H_ 150 #endif // V8_INSPECTOR_V8INSPECTORIMPL_H_
OLDNEW
« no previous file with comments | « src/inspector/V8InjectedScriptHost.cpp ('k') | src/inspector/V8InspectorImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698