Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 2331423008: MD Settings: Search Engines: Move dropdown menu to search_engines_list (Closed)

Created:
4 years, 3 months ago by stevenjb
Modified:
4 years ago
Reviewers:
CC:
arv+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, extensions-reviews_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Search Engines: Move dropdown menu to search_engines_list This moves the dropdown out of the individual list items and unifies the menu handling code in search_engine_list. It also updates the CSS to use the shared styling and fixes keyboard focus for 'Add search engine'. BUG=639718 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Messages

Total messages: 11 (4 generated)
stevenjb
4 years, 3 months ago (2016-09-15 22:54:48 UTC) #4
dpapad
https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html File chrome/browser/resources/settings/search_engines_page/search_engines_list.html (right): https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html#newcode50 chrome/browser/resources/settings/search_engines_page/search_engines_list.html:50: <iron-dropdown horizontal-align="right" vertical-align="auto"> Can we encapsulate the menu inside ...
4 years, 3 months ago (2016-09-15 23:14:13 UTC) #5
dpapad
On 2016/09/15 at 23:14:13, dpapad wrote: > https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html > File chrome/browser/resources/settings/search_engines_page/search_engines_list.html (right): > > https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html#newcode50 ...
4 years, 3 months ago (2016-09-15 23:18:20 UTC) #6
stevenjb
https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html File chrome/browser/resources/settings/search_engines_page/search_engines_list.html (right): https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html#newcode50 chrome/browser/resources/settings/search_engines_page/search_engines_list.html:50: <iron-dropdown horizontal-align="right" vertical-align="auto"> On 2016/09/15 23:14:12, dpapad wrote: > ...
4 years, 3 months ago (2016-09-15 23:35:55 UTC) #7
dpapad
On 2016/09/15 at 23:35:55, stevenjb wrote: > https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html > File chrome/browser/resources/settings/search_engines_page/search_engines_list.html (right): > > https://codereview.chromium.org/2331423008/diff/20001/chrome/browser/resources/settings/search_engines_page/search_engines_list.html#newcode50 ...
4 years, 3 months ago (2016-09-15 23:45:46 UTC) #8
stevenjb
On 2016/09/15 23:45:46, dpapad wrote: > On 2016/09/15 at 23:35:55, stevenjb wrote: > > > ...
4 years, 3 months ago (2016-09-16 03:22:24 UTC) #9
dpapad
4 years, 2 months ago (2016-10-18 00:49:19 UTC) #10
FYI, you can probably delete/close this CL now.

Powered by Google App Engine
This is Rietveld 408576698