Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7019)

Unified Diff: chrome/browser/resources/settings/search_engines_page/search_engines_page.html

Issue 2331423008: MD Settings: Search Engines: Move dropdown menu to search_engines_list (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/search_engines_page.html
diff --git a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
index 0cd7c510880907973b874b16ec9cc2843fcab2c0..6cbe84c1bdb0d47b92b80bf9c2bf234a75aabc69 100644
--- a/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
+++ b/chrome/browser/resources/settings/search_engines_page/search_engines_page.html
@@ -14,10 +14,6 @@
<link rel="import" type="css" href="chrome://resources/css/action_link.css">
<template>
<style include="settings-shared">
- .extension-engines {
- @apply(--settings-list-frame-padding);
- }
-
settings-omnibox-extension-entry {
border-top: var(--settings-separator-line);
}
@@ -31,32 +27,26 @@
</div>
<settings-search-engines-list engines="[[defaultEngines]]">
</settings-search-engines-list>
- <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
- <settings-search-engine-dialog></settings-search-engine-dialog>
- </template>
<div class="settings-box first">
<h2>$i18n{searchEnginesOther}</h2>
</div>
- <!-- TODO(dbeam): why does on-click work with keyboard but on-tap
- doesn't? -->
- <settings-search-engines-list engines="[[otherEngines]]">
- <a class="list-item list-button" is="action-link"
+ <div class="list-frame">
+ <a class="list-item list-button" is="action-link" actionable
on-tap="onAddSearchEngineTap_" id="addSearchEngine">
- $i18n{searchEnginesAddSearchEngine}</a>
+ $i18n{searchEnginesAddSearchEngine}</a>
+ </div>
+ <settings-search-engines-list engines="[[otherEngines]]">
</settings-search-engines-list>
-
<template is="dom-if" if="[[showExtensionsList_]]">
<div class="settings-box first">
<h2>$i18n{searchEnginesExtension}</h2>
</div>
- <iron-list id="extensions" class="extension-engines" selectable
- items="[[extensions]]">
- <template>
- <settings-omnibox-extension-entry engine="[[item]]"
- tabindex$="[[tabIndex]]">
- </settings-omnibox-extension-entry>
- </template>
- </iron-list>
+ <settings-search-engines-list engines="[[extensions]]">
+ </settings-search-engines-list>
+ </template>
+ <template is="dom-if" if="[[showAddSearchEngineDialog_]]" restamp>
+ <settings-search-engine-dialog>
+ </settings-search-engine-dialog>
</template>
</template>
<script src="search_engines_page.js"></script>

Powered by Google App Engine
This is Rietveld 408576698