Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js

Issue 2331423008: MD Settings: Search Engines: Move dropdown menu to search_engines_list (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
diff --git a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
index 0ed0c9f5cd1edab48fbddc81f32c15713c8f1c24..4c3463feb9960ffede0ea448265e19bac71d2b2e 100644
--- a/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
+++ b/chrome/browser/resources/settings/search_engines_page/omnibox_extension_entry.js
@@ -12,31 +12,6 @@ Polymer({
properties: {
/** @type {!SearchEngine} */
engine: Object,
-
- /** @private {!settings.SearchEnginesBrowserProxy} */
- browserProxy_: Object,
- },
-
- /** @override */
- created: function() {
- this.browserProxy_ = settings.SearchEnginesBrowserProxyImpl.getInstance();
- },
-
- /** @private */
- onManageTap_: function() {
- this.closePopupMenu_();
- this.browserProxy_.manageExtension(this.engine.extension.id);
- },
-
- /** @private */
- onDisableTap_: function() {
- this.closePopupMenu_();
- this.browserProxy_.disableExtension(this.engine.extension.id);
- },
-
- /** @private */
- closePopupMenu_: function() {
- this.$$('iron-dropdown').close();
},
/**
@@ -47,4 +22,9 @@ Polymer({
getIconSet_: function(url) {
return cr.icon.getFavicon(url);
},
+
+ /** @private */
+ onOpenMenuTap_() {
+ this.fire('open-menu', this.engine);
+ },
});

Powered by Google App Engine
This is Rietveld 408576698