Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Unified Diff: components/metrics/metrics_service_accessor.h

Issue 2331343012: Create MetricsPrivateDelegate for metricsPrivate behavior (Closed)
Patch Set: ExtensionsAPIClient owns MetricsPrivateDelegate instance Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/metrics/metrics_service_accessor.h
diff --git a/components/metrics/metrics_service_accessor.h b/components/metrics/metrics_service_accessor.h
index eabf8a122391e27c6bf3eac08ed15c6ab94ee2ad..5d02555d5e2646e45974ec2036f44e4fb4085d57 100644
--- a/components/metrics/metrics_service_accessor.h
+++ b/components/metrics/metrics_service_accessor.h
@@ -29,8 +29,8 @@ class MetricsServiceAccessor {
// Returns whether metrics reporting is enabled, using the value of the
// kMetricsReportingEnabled pref in |pref_service| to determine whether user
// has enabled reporting.
- // NOTE: This method currently does not return the correct value on ChromeOS
- // and Android due to http://crbug.com/362192 and http://crbug.com/532084. See
+ // NOTE: This method currently does not return the correct value on Android
Ilya Sherman 2016/09/23 22:39:59 Is your CL changing something about the correctnes
michaelpg 2016/09/23 23:48:15 No. The method seems to have already been correcte
Ilya Sherman 2016/09/27 01:33:13 Yes please, and send the code review to gayane@, a
michaelpg 2016/09/27 16:45:16 Looks like gayane@ beat me to it! https://coderevi
Ilya Sherman 2016/09/27 21:16:49 Great! Please make sure to remember to revert you
michaelpg 2016/09/30 22:15:01 Done.
+ // due to http://crbug.com/362192 and http://crbug.com/532084. See
// ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled().
static bool IsMetricsReportingEnabled(PrefService* pref_service);

Powered by Google App Engine
This is Rietveld 408576698