Create MetricsPrivateDelegate for metricsPrivate behavior

components/metrics/metrics_service_accessor.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_METRICS_METRICS_SERVICE_ACCESSOR_H_
 #define COMPONENTS_METRICS_METRICS_SERVICE_ACCESSOR_H_
 
 #include <stdint.h>
 #include <string>
 #include <vector>
@@ skipping 11 matching lines @@
 // specialization and enable access there by declaring friends.
 class MetricsServiceAccessor {
  protected:
   // Constructor declared as protected to enable inheritance. Descendants should
   // disallow instantiation.
   MetricsServiceAccessor() {}
 
   // Returns whether metrics reporting is enabled, using the value of the
   // kMetricsReportingEnabled pref in |pref_service| to determine whether user
   // has enabled reporting.
-  // NOTE: This method currently does not return the correct value on ChromeOS
-  // and Android due to http://crbug.com/362192 and http://crbug.com/532084. See
+  // NOTE: This method currently does not return the correct value on Android

[Ilya Sherman, 2016/09/23 22:39:59]

Is your CL changing something about the correctness of this method's return
value on ChromeOS?

[michaelpg, 2016/09/23 23:48:15]

No. The method seems to have already been corrected on Chrome OS in November,
making the comment incorrect:
  https://bugs.chromium.org/p/chromium/issues/detail?id=532084#c3

If that's correct, would you prefer me to make this comment change in a
separate CL?

[Ilya Sherman, 2016/09/27 01:33:13]

Yes please, and send the code review to gayane@, as she is the most familiar
with the details of this code currently =)

[michaelpg, 2016/09/27 16:45:16]

Looks like gayane@ beat me to it! https://codereview.chromium.org/2351873002

[Ilya Sherman, 2016/09/27 21:16:49]

Great!  Please make sure to remember to revert your changes to this file =)

[michaelpg, 2016/09/30 22:15:01]

Done.

+  // due to http://crbug.com/362192 and http://crbug.com/532084. See
   // ChromeMetricsServiceAccessor::IsMetricsAndCrashReportingEnabled().
   static bool IsMetricsReportingEnabled(PrefService* pref_service);
 
   // Returns whether metrics reporting is enabled, using the value of
   // |enabled_in_prefs| to determine whether the user has enabled reporting.
   // Exists because kMetricsReportingEnabled is currently not used on all
   // platforms.
   // TODO(gayane): Consolidate metric prefs on all platforms and eliminate this
   // method.  http://crbug.com/362192, http://crbug.com/532084
   static bool IsMetricsReportingEnabledWithPrefValue(bool enabled_in_prefs);
@@ skipping 31 matching lines @@
       uint32_t trial_name_hash,
       uint32_t group_name_hash);
 
  private:
   DISALLOW_COPY_AND_ASSIGN(MetricsServiceAccessor);
 };
 
 }  // namespace metrics
 
 #endif  // COMPONENTS_METRICS_METRICS_SERVICE_ACCESSOR_H_