Clean up UMA 3g experiment and unify metrics enabled pref for Android

Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to
kMetricsReportingEnabled

BUG=532084, 455847
Committed: https://crrev.com/510bab1117acacb20b58cbda3479244116baa87e
Cr-Commit-Position: refs/heads/master@{#420663}

[gayane -on leave until 09-2017, 2016-09-19 19:27:11]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref

BUG=
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to
kMetricsReportingEnabled

BUG=532084, 455847
==========

[gayane -on leave until 09-2017, 2016-09-19 19:27:31]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to
kMetricsReportingEnabled

BUG=532084, 455847
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but 
leaving the experiment imposed behavior. It also removes the 
use of Android only metrics enabled pref 
kCrashReportingEnabled as now we are fully transitioned to 
kMetricsReportingEnabled

BUG=532084, 455847
==========

[gayane -on leave until 09-2017, 2016-09-19 19:28:29]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but 
leaving the experiment imposed behavior. It also removes the 
use of Android only metrics enabled pref 
kCrashReportingEnabled as now we are fully transitioned to 
kMetricsReportingEnabled

BUG=532084, 455847
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

[gayane -on leave until 09-2017, 2016-09-19 19:28:44]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

[gayane -on leave until 09-2017, 2016-09-19 19:29:11]

The CQ bit was checked by gayane@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 19:29:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gayane -on leave until 09-2017, 2016-09-19 19:29:54]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2016-09-19 19:29:55]

PTAL

This is N1 of my UMA 3g experiment clean up CLs

[Alexei Svitkine (slow), 2016-09-19 19:38:02]

Looks great, thanks!

https://codereview.chromium.org/2351873002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/2351873002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:408: #if
BUILDFLAG(ANDROID_JAVA_UI)
Add a comment about this explaining what this with a TODO to remove this in some
number of milestones (e.g. M60). Actually, I see the comment is above the
local_state line - move it below and add an empty line after the local state var
- since it's used for other things below too.

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
File components/metrics/net/cellular_logic_helper.cc (left):

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
components/metrics/net/cellular_logic_helper.cc:28: #endif
Shouldn't we keep this logic - given that we still only want to enable it on
Android and not other platforms for now?

[gayane -on leave until 09-2017, 2016-09-19 20:05:58]

Thanks have one more look

https://codereview.chromium.org/2351873002/diff/1/chrome/browser/metrics/chro...
File chrome/browser/metrics/chrome_metrics_service_client.cc (right):

https://codereview.chromium.org/2351873002/diff/1/chrome/browser/metrics/chro...
chrome/browser/metrics/chrome_metrics_service_client.cc:408: #if
BUILDFLAG(ANDROID_JAVA_UI)
On 2016/09/19 19:38:02, Alexei Svitkine (very slow) wrote:
> Add a comment about this explaining what this with a TODO to remove this in
some
> number of milestones (e.g. M60). Actually, I see the comment is above the
> local_state line - move it below and add an empty line after the local state
var
> - since it's used for other things below too.

Done.

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
File components/metrics/net/cellular_logic_helper.cc (left):

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
components/metrics/net/cellular_logic_helper.cc:28: #endif
On 2016/09/19 19:38:02, Alexei Svitkine (very slow) wrote:
> Shouldn't we keep this logic - given that we still only want to enable it on
> Android and not other platforms for now?

Brought back the defaults but still removed the experiment code. 
Should I also get ride of kDefaultCellularLogicOptimization which we introduced
very early in experiments but it was never really useful

[Alexei Svitkine (slow), 2016-09-19 20:36:56]

LGTM % comment

Thanks!

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
File components/metrics/net/cellular_logic_helper.cc (left):

https://codereview.chromium.org/2351873002/diff/1/components/metrics/net/cell...
components/metrics/net/cellular_logic_helper.cc:28: #endif
On 2016/09/19 20:05:58, gayane wrote:
> On 2016/09/19 19:38:02, Alexei Svitkine (very slow) wrote:
> > Shouldn't we keep this logic - given that we still only want to enable it on
> > Android and not other platforms for now?
> 
> Brought back the defaults but still removed the experiment code. 
> Should I also get ride of kDefaultCellularLogicOptimization which we
introduced
> very early in experiments but it was never really useful 

Given that in this file the extra boolean is not doing anything that the first
boolean isn't doing, I think it's fine to remove here and just use the one
boolean.

[gayane -on leave until 09-2017, 2016-09-19 22:07:30]

gayane@chromium.org changed reviewers:
+ anthonyvd@chromium.org

[gayane -on leave until 09-2017, 2016-09-19 22:07:31]

anthonyvd@chromium.org: PTAL for owners review for

chrome/browser/profiles/profile_io_data.cc

[anthonyvd, 2016-09-23 16:56:37]

On 2016/09/19 22:07:31, gayane wrote:
> mailto:anthonyvd@chromium.org: PTAL for owners review for
> 
> chrome/browser/profiles/profile_io_data.cc

Sorry for the delay, c/b/profiles/profile_io_data.cc lgtm

[gayane -on leave until 09-2017, 2016-09-23 17:09:31]

The CQ bit was checked by gayane@chromium.org

[gayane -on leave until 09-2017, 2016-09-23 17:09:32]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2351873002/#ps40001
(title: "remove optimization param")

[commit-bot: I haz the power, 2016-09-23 17:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 18:14:35]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

[commit-bot: I haz the power, 2016-09-23 18:14:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-23 18:17:16]

Description was changed from

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to  
kMetricsReportingEnabled

BUG=532084, 455847
==========

to

==========
Clean up UMA 3g experiment and unify metrics enabled pref for Android.

This change cleans up UMA 3g experiment related code, but leaving the experiment
imposed behavior. It also removes the use of Android only metrics enabled pref
kCrashReportingEnabled as now we are fully transitioned to
kMetricsReportingEnabled

BUG=532084, 455847

Committed: https://crrev.com/510bab1117acacb20b58cbda3479244116baa87e
Cr-Commit-Position: refs/heads/master@{#420663}
==========

[commit-bot: I haz the power, 2016-09-23 18:17:17]

Patchset 3 (id:??) landed as
https://crrev.com/510bab1117acacb20b58cbda3479244116baa87e
Cr-Commit-Position: refs/heads/master@{#420663}