Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2331193005: Add EOF signal in FilterSourceStream::FilterData() (Closed)

Created:
4 years, 3 months ago by xunjieli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add EOF signal in FilterSourceStream::FilterData() Add a bool argument in FilterData() to signal that upstream's eof has been reached. R=rdsmith@chromium.org BUG=474859 Committed: https://crrev.com/9e0e8b2bd96ede88c633fe62fe24dc20c24559f7 Cr-Commit-Position: refs/heads/master@{#418713}

Patch Set 1 : self review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -25 lines) Patch
M net/filter/filter_source_stream.h View 1 chunk +3 lines, -2 lines 0 comments Download
M net/filter/filter_source_stream.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/filter/filter_source_stream_unittest.cc View 9 chunks +44 lines, -21 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
xunjieli
Thanks for the feedback on the earlier CL. Sorry for misunderstanding some of the suggestions. ...
4 years, 3 months ago (2016-09-13 20:16:22 UTC) #3
Randy Smith (Not in Mondays)
LGTM (ignore my offline comment; after some thought, I think the comments before the test ...
4 years, 3 months ago (2016-09-14 21:21:20 UTC) #8
xunjieli
On 2016/09/14 21:21:20, Randy Smith - Not in Fridays wrote: > LGTM (ignore my offline ...
4 years, 3 months ago (2016-09-14 21:25:12 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2331193005/20001
4 years, 3 months ago (2016-09-14 21:25:52 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-14 23:09:17 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 23:13:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e0e8b2bd96ede88c633fe62fe24dc20c24559f7
Cr-Commit-Position: refs/heads/master@{#418713}

Powered by Google App Engine
This is Rietveld 408576698