Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3271)

Unified Diff: net/filter/filter_source_stream.h

Issue 2331193005: Add EOF signal in FilterSourceStream::FilterData() (Closed)
Patch Set: self review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/filter/filter_source_stream.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/filter/filter_source_stream.h
diff --git a/net/filter/filter_source_stream.h b/net/filter/filter_source_stream.h
index f2778dbdc77181134730afe409c4107573fc8827..562717f52fa51e3cd34ce5045b1d542739eb5f5c 100644
--- a/net/filter/filter_source_stream.h
+++ b/net/filter/filter_source_stream.h
@@ -69,12 +69,13 @@ class NET_EXPORT_PRIVATE FilterSourceStream : public SourceStream {
// FilterData() will be repeatedly invoked with the same |input_buffer| until
// FilterData() returns 0 or an error. If FilterData() returns 0,
// |input_buffer| must be fully drained. Upstream EOF is reached when
- // FilterData() is called with |input_buffer->BytesRemaining() == 0|.
+ // FilterData() is called with |upstream_eof_reached| = true.
// TODO(xunjieli): consider allowing asynchronous response via callback
// to support off-thread decompression.
virtual int FilterData(IOBuffer* output_buffer,
int output_buffer_size,
- DrainableIOBuffer* input_buffer) = 0;
+ DrainableIOBuffer* input_buffer,
+ bool upstream_eof_reached) = 0;
// Returns a string representation of the type of this FilterSourceStream.
// This is for UMA logging.
« no previous file with comments | « no previous file | net/filter/filter_source_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698