Change DrainableIOBuffer to IBuffer and int* in FilterData() arguments

Change DrainableIOBuffer to IBuffer and int* in FilterData() arguments

R=mmenke@chromium.org
CC=rdsmith@chromium.org

BUG=474859
Committed: https://crrev.com/e4fd0c7797892096e05fc556ece67ad5e3f46fdb
Cr-Commit-Position: refs/heads/master@{#418951}

[xunjieli, 2016-09-13 20:29:49]

PTAL. Thanks!

[mmenke, 2016-09-13 20:52:34]

LGTM

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
File net/filter/filter_source_stream.cc (right):

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
net/filter/filter_source_stream.cc:133: &consumed_bytes, upstream_end_reached_);
Maybe add:

DCHECK_LE(consumed_bytes, drainable_input_buffer_->BytesRemaining());
DCHECK(bytes_output != 0 || consumed_bytes ==
drainable_input_buffer_->BytesRemaining());

[Randy Smith (Not in Mondays), 2016-09-14 21:22:57]

rdsmith@chromium.org changed reviewers:
+ rdsmith@chromium.org

[Randy Smith (Not in Mondays), 2016-09-14 21:22:57]

LGTM.  Thanks for your patience with all these interface tweaks.

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
File net/filter/filter_source_stream.cc (right):

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
net/filter/filter_source_stream.cc:133: &consumed_bytes, upstream_end_reached_);
On 2016/09/13 20:52:34, mmenke wrote:
> Maybe add:
> 
> DCHECK_LE(consumed_bytes, drainable_input_buffer_->BytesRemaining());
> DCHECK(bytes_output != 0 || consumed_bytes ==
> drainable_input_buffer_->BytesRemaining());

+1 (suggestion level).

[xunjieli, 2016-09-15 14:20:05]

Thanks for the review!

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
File net/filter/filter_source_stream.cc (right):

https://codereview.chromium.org/2338043002/diff/1/net/filter/filter_source_st...
net/filter/filter_source_stream.cc:133: &consumed_bytes, upstream_end_reached_);
On 2016/09/13 20:52:34, mmenke wrote:
> Maybe add:
> 
> DCHECK_LE(consumed_bytes, drainable_input_buffer_->BytesRemaining());
> DCHECK(bytes_output != 0 || consumed_bytes ==
> drainable_input_buffer_->BytesRemaining());

Done.

[xunjieli, 2016-09-15 14:20:08]

The CQ bit was checked by xunjieli@chromium.org

[xunjieli, 2016-09-15 14:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdsmith@chromium.org, mmenke@chromium.org
Link to the patchset: https://codereview.chromium.org/2338043002/#ps20001
(title: "rebased to r418859 and add DCHECKs")

[commit-bot: I haz the power, 2016-09-15 14:20:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 16:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 16:18:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xunjieli, 2016-09-15 18:29:01]

The CQ bit was checked by xunjieli@chromium.org

[commit-bot: I haz the power, 2016-09-15 18:29:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 20:20:41]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-15 20:22:40]

Description was changed from

==========
Change DrainableIOBuffer to IBuffer and int* in FilterData() arguments

R=mmenke@chromium.org
CC=rdsmith@chromium.org

BUG=474859
==========

to

==========
Change DrainableIOBuffer to IBuffer and int* in FilterData() arguments

R=mmenke@chromium.org
CC=rdsmith@chromium.org

BUG=474859

Committed: https://crrev.com/e4fd0c7797892096e05fc556ece67ad5e3f46fdb
Cr-Commit-Position: refs/heads/master@{#418951}
==========

[commit-bot: I haz the power, 2016-09-15 20:22:42]

Patchset 2 (id:??) landed as
https://crrev.com/e4fd0c7797892096e05fc556ece67ad5e3f46fdb
Cr-Commit-Position: refs/heads/master@{#418951}