Add BarChart.

Add BarChart.

Currently, ColumnChart draws vertical columns, but there is no equivalent chart for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override them.

BUG=catapult:#2677

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/c42044026b814c6c090b70879ffc571aff8dcf1c

[benjhayden, 2016-09-11 05:16:39]

Description was changed from

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart,
and a new BarChart is added as a subclass that transposes the axes.
==========

to

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.
==========

[benjhayden, 2016-09-11 05:38:39]

Patchset #1 (id:1) has been deleted

[benjhayden, 2016-09-11 05:38:47]

Patchset #1 (id:20001) has been deleted

[benjhayden, 2016-09-11 05:40:00]

Description was changed from

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.
==========

to

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.
==========

[benjhayden, 2016-09-11 05:45:40]

Description was changed from

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.
==========

to

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.

A constant-height bar (or constant-width column) mode (for exotic histogram bin
configurations) is left for another CL.
==========

[benjhayden, 2016-09-11 05:46:42]

Patchset #1 (id:40001) has been deleted

[benjhayden, 2016-09-11 05:58:20]

benjhayden@chromium.org changed reviewers:
+ aiolos@chromium.org, eakuefner@chromium.org, nduca@chromium.org

[benjhayden, 2016-09-11 05:58:21]

PTAL :-)

Please review the inheritance hierarchy for any other math that BarChart needs
to override.
ChartBase > ChartBase2D > ChartBase2DBrushableX > ColumnChart > BarChart
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/b...
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/b...
https://github.com/catapult-project/catapult/blob/master/tracing/tracing/ui/b...


Feel free to either carefully review the tricky math in BarChart that transposes
the axes,
or else assume that it must be correct since the test charts look right. :-)

[benjhayden, 2016-09-11 05:59:17]

Description was changed from

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.

A constant-height bar (or constant-width column) mode (for exotic histogram bin
configurations) is left for another CL.
==========

to

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.

A constant-height bar (or constant-width column) mode (for exotic histogram bin
configurations) is left for another CL.

BUG=catapult:#2677
==========

[benjhayden, 2016-09-11 22:30:15]

benjhayden@chromium.org changed reviewers:
+ fmeawad@chromium.org

[benjhayden, 2016-09-11 22:30:15]

+fmeawad FYI, feel free to review or not as you wish. :-)

[benjhayden, 2016-09-12 23:17:15]

Why don't I split this into a CL that renames BarChart to ColumnChart, and a CL
that adds (horizontal) BarChart? :-)

[aiolos (Not reviewing), 2016-09-12 23:21:07]

On 2016/09/12 23:17:15, benjhayden wrote:
> Why don't I split this into a CL that renames BarChart to ColumnChart, and a
CL
> that adds (horizontal) BarChart? :-)

+1

[benjhayden, 2016-09-12 23:32:26]

Hold this CL; review this one first: https://codereview.chromium.org/2334973002

[benjhayden, 2016-09-13 03:05:05]

Description was changed from

==========
Add ColumnChart.

Actually, the existing BarChart is renamed to ColumnChart to reflect gchart's
usage of the names, and a new BarChart is added as a subclass that transposes
the
axes.

Several chunks of code are factored out into methods so that BarChart can
override them.

A constant-height bar (or constant-width column) mode (for exotic histogram bin
configurations) is left for another CL.

BUG=catapult:#2677
==========

to

==========
Add BarChart.

BarChart extends ColumnChart, but transposes the axes.

BUG=catapult:#2677
==========

[benjhayden, 2016-09-13 03:06:38]

Description was changed from

==========
Add BarChart.

BarChart extends ColumnChart, but transposes the axes.

BUG=catapult:#2677
==========

to

==========
Add BarChart.

Currently, ColumnChart draws vertical columns, but we have no equivalent chart
for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override
them.

BUG=catapult:#2677
==========

[benjhayden, 2016-09-13 03:06:52]

Description was changed from

==========
Add BarChart.

Currently, ColumnChart draws vertical columns, but we have no equivalent chart
for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override
them.

BUG=catapult:#2677
==========

to

==========
Add BarChart.

Currently, ColumnChart draws vertical columns, but there is no equivalent chart
for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override
them.

BUG=catapult:#2677
==========

[benjhayden, 2016-09-13 04:12:28]

OK, ready.
You can read each patch 2-6 separately as a series of refactors to create
overrideable methods, then patch 7 overrides all the new methods.
If you know how tumbler locks work, patches 2-6 align one tumbler at a time,
then patch 7 turns the key to flip all the tumblers at once.
We can sit down and review this tomorrow together.

[benjhayden, 2016-09-13 21:10:22]

debug stacked

https://codereview.chromium.org/2329843002/diff/180001/tracing/tracing/ui/bas...
File tracing/tracing/ui/base/bar_chart.html (right):

https://codereview.chromium.org/2329843002/diff/180001/tracing/tracing/ui/bas...
tracing/tracing/ui/base/bar_chart.html:39: .attr('y', function(d) {
use arrows

https://codereview.chromium.org/2329843002/diff/180001/tracing/tracing/ui/bas...
tracing/tracing/ui/base/bar_chart.html:66: var scale = this.isYLogScale_ ?
d3.scale.log(10) : d3.scale.linear();
factor to share with drawBrush_

https://codereview.chromium.org/2329843002/diff/180001/tracing/tracing/ui/bas...
tracing/tracing/ui/base/bar_chart.html:93: chartAreaSel
can this share more code with BrushableX?

https://codereview.chromium.org/2329843002/diff/180001/tracing/tracing/ui/bas...
tracing/tracing/ui/base/bar_chart.html:121: var colRect = {
// Rotate clockwise by 90 degrees, then flip horizontally because neither width
nor height can be negative.

[eakuefner, 2016-09-13 21:18:48]

lgtm

[aiolos (Not reviewing), 2016-09-13 21:19:25]

lgtm once the stacked chart is debugged.

[benjhayden, 2016-09-14 01:24:33]

I was trying to be too clever in BarChart.drawRect_. widthPx should just be
heightPx, not width - topPx. That fixed the stacking.

Thanks for the review!

[benjhayden, 2016-09-14 01:24:37]

The CQ bit was checked by benjhayden@chromium.org

[benjhayden, 2016-09-14 01:24:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
eakuefner@chromium.org, aiolos@chromium.org
Link to the patchset: https://codereview.chromium.org/2329843002/#ps220001
(title: "BarChart horizontal and vertical scales")

[commit-bot: I haz the power, 2016-09-14 01:24:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:46:43]

Description was changed from

==========
Add BarChart.

Currently, ColumnChart draws vertical columns, but there is no equivalent chart
for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override
them.

BUG=catapult:#2677
==========

to

==========
Add BarChart.

Currently, ColumnChart draws vertical columns, but there is no equivalent chart
for
horizontal bars.

BarChart extends ColumnChart, but transposes the axes so that bars are drawn
horizontally.
This required factoring parts of the base classes to allow BarChart to override
them.

BUG=catapult:#2677

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-09-14 01:46:44]

Committed patchset #9 (id:220001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...