tracing/tracing/ui/base/chart_base_2d_brushable_x.html - Issue 2329843002: Add BarChart.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tracing/tracing/ui/base/chart_base_2d_brushable_x.html

Issue 2329843002: Add BarChart. (Closed)

Patch Set: BarChart horizontal and vertical scales Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tracing/tracing/ui/base/chart_base_2d_brushable_x.html

diff --git a/tracing/tracing/ui/base/chart_base_2d_brushable_x.html b/tracing/tracing/ui/base/chart_base_2d_brushable_x.html

index 4cde4b58bdd70519c63ca95cf3a8f9c215dfa2f7..5d2f799945e8fb0f07d6146ebad0471b72836bae 100644

--- a/tracing/tracing/ui/base/chart_base_2d_brushable_x.html

+++ b/tracing/tracing/ui/base/chart_base_2d_brushable_x.html

@@ -65,6 +65,10 @@ tr.exportTo('tr.ui.b', function() {

var brushRectsSel = brushSel.selectAll('rect').data(brushes);

brushRectsSel.enter().append('rect');

brushRectsSel.exit().remove();

+ this.drawBrush_(brushRectsSel);

+ },

+ drawBrush_: function(brushRectsSel) {

brushRectsSel

.attr('x', function(d) {

return this.xScale_(d.min);