Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 2334973002: Rename BarChart to ColumnChart (Closed)

Created:
4 years, 3 months ago by benjhayden
Modified:
4 years, 3 months ago
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rename BarChart to ColumnChart This reflects gchart's usage of the name. The "bars" are vertical, like columns. A separate patch will add a new "BarChart" with horizontal bars, following gchart's usage of the names. BUG=catapult:#2677 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/02ce874300f5919c3a2d25d2609487a4f0eec331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -573 lines) Patch
M tracing/trace_viewer.gypi View 1 chunk +1 line, -1 line 0 comments Download
D tracing/tracing/ui/base/bar_chart.html View 1 chunk +0 lines, -251 lines 0 comments Download
D tracing/tracing/ui/base/bar_chart_test.html View 1 chunk +0 lines, -293 lines 0 comments Download
A + tracing/tracing/ui/base/column_chart.html View 2 chunks +6 lines, -6 lines 0 comments Download
A + tracing/tracing/ui/base/column_chart_test.html View 12 chunks +13 lines, -13 lines 0 comments Download
M tracing/tracing/ui/base/name_bar_chart.html View 1 chunk +5 lines, -5 lines 0 comments Download
M tracing/tracing/value/ui/composition_span.html View 2 chunks +2 lines, -2 lines 0 comments Download
M tracing/tracing/value/ui/histogram_span.html View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
benjhayden
PTAL :-)
4 years, 3 months ago (2016-09-12 23:31:45 UTC) #3
aiolos (Not reviewing)
lgtm
4 years, 3 months ago (2016-09-12 23:35:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2334973002/1
4 years, 3 months ago (2016-09-12 23:48:12 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-13 00:09:48 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698