Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Side by Side Diff: blimp/client/core/compositor/delegated_output_surface.h

Issue 2329623003: cc: Remove unneeded methods from OutputSurface. (Closed)
Patch Set: shrink-os-api: moreblimp Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_ 5 #ifndef BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_
6 #define BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_ 6 #define BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 bool BindToClient(cc::OutputSurfaceClient* client) override; 42 bool BindToClient(cc::OutputSurfaceClient* client) override;
43 void SwapBuffers(cc::CompositorFrame frame) override; 43 void SwapBuffers(cc::CompositorFrame frame) override;
44 void DetachFromClient() override; 44 void DetachFromClient() override;
45 45
46 // BlimpOutputSurface implementation. 46 // BlimpOutputSurface implementation.
47 void ReclaimCompositorResources( 47 void ReclaimCompositorResources(
48 const cc::ReturnedResourceArray& resources) override; 48 const cc::ReturnedResourceArray& resources) override;
49 49
50 private: 50 private:
51 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_; 51 scoped_refptr<base::SingleThreadTaskRunner> main_task_runner_;
52 base::WeakPtr<BlimpOutputSurfaceClient> client_; 52 base::WeakPtr<BlimpOutputSurfaceClient> blimp_client_;
danakj 2016/09/10 00:58:24 I renamed this because the base class has a client
Wez 2016/09/12 00:06:44 SGTM, although I think we should review this Blimp
53 53
54 bool bound_to_client_; 54 bool bound_to_client_;
55 55
56 // This OutputSurface is responsible for providing the BeginFrameSource to 56 // This OutputSurface is responsible for providing the BeginFrameSource to
57 // drive frame creation. This will be built on the compositor impl thread at 57 // drive frame creation. This will be built on the compositor impl thread at
58 // BindToClient call time. 58 // BindToClient call time.
59 std::unique_ptr<cc::BeginFrameSource> begin_frame_source_; 59 std::unique_ptr<cc::BeginFrameSource> begin_frame_source_;
60 60
61 base::WeakPtrFactory<DelegatedOutputSurface> weak_factory_; 61 base::WeakPtrFactory<DelegatedOutputSurface> weak_factory_;
62 62
63 DISALLOW_COPY_AND_ASSIGN(DelegatedOutputSurface); 63 DISALLOW_COPY_AND_ASSIGN(DelegatedOutputSurface);
64 }; 64 };
65 65
66 } // namespace client 66 } // namespace client
67 } // namespace blimp 67 } // namespace blimp
68 68
69 #endif // BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_ 69 #endif // BLIMP_CLIENT_CORE_COMPOSITOR_DELEGATED_OUTPUT_SURFACE_H_
OLDNEW
« no previous file with comments | « android_webview/browser/parent_output_surface.cc ('k') | blimp/client/core/compositor/delegated_output_surface.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698