Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 2329573002: Refactor base's proguard flags to be more usable by cronet (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, android-webview-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor base's proguard flags to be more usable by cronet Verified that Chrome.apk is the same size before & after this change. BUG=645529 Committed: https://crrev.com/91d7a9e6f0e2c871b2d3982b2ba8526947a8b231 Cr-Commit-Position: refs/heads/master@{#418019}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -111 lines) Patch
M android_webview/system_webview_apk_tmpl.gni View 1 chunk +2 lines, -2 lines 0 comments Download
D base/android/base_proguard_config.flags View 1 chunk +0 lines, -59 lines 0 comments Download
A + base/android/proguard/chromium_apk.flags View 1 chunk +27 lines, -0 lines 0 comments Download
A + base/android/proguard/chromium_code.flags View 3 chunks +14 lines, -11 lines 0 comments Download
D base/android/release_proguard_config.flags View 1 chunk +0 lines, -32 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M components/cronet/android/BUILD.gn View 3 chunks +5 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
agrieve
xunjieli@chromium.org: Please review changes in cronet michaelbai@chromium.org: Please review changes in webview pkotwicz@chromium.org: Please review ...
4 years, 3 months ago (2016-09-09 19:39:50 UTC) #2
xunjieli
On 2016/09/09 19:39:50, agrieve wrote: > mailto:xunjieli@chromium.org: Please review changes in cronet LGTM. This will ...
4 years, 3 months ago (2016-09-09 19:51:59 UTC) #6
michaelbai
LGTM for android_webview
4 years, 3 months ago (2016-09-09 21:21:36 UTC) #9
pkotwicz
👍 webapk LGTM
4 years, 3 months ago (2016-09-12 18:13:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329573002/1
4 years, 3 months ago (2016-09-12 18:16:41 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-12 20:09:37 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 20:12:46 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/91d7a9e6f0e2c871b2d3982b2ba8526947a8b231
Cr-Commit-Position: refs/heads/master@{#418019}

Powered by Google App Engine
This is Rietveld 408576698