Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: base/android/proguard/chromium_apk.flags

Issue 2329573002: Refactor base's proguard flags to be more usable by cronet (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/base_proguard_config.flags ('k') | base/android/proguard/chromium_code.flags » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/proguard/chromium_apk.flags
diff --git a/base/android/release_proguard_config.flags b/base/android/proguard/chromium_apk.flags
similarity index 57%
rename from base/android/release_proguard_config.flags
rename to base/android/proguard/chromium_apk.flags
index d339df5d97e36e7d4d1831cafc04b4f047606cbf..b5ffb7f3013c01b5c9c5acd203350c867e08c4c5 100644
--- a/base/android/release_proguard_config.flags
+++ b/base/android/proguard/chromium_apk.flags
@@ -1,3 +1,30 @@
+# Copyright 2016 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Contains flags that we'd like all Chromium .apks to use.
+
+# Keep line number information, useful for stack traces.
+-keepattributes SourceFile,LineNumberTable
+
+# Keep all CREATOR fields within Parcelable that are kept.
+-keepclassmembers class * implements android.os.Parcelable {
+ public static *** CREATOR;
+}
+
+# Don't obfuscate Parcelables as they might be marshalled outside Chrome.
+# If we annotated all Parcelables that get put into Bundles other than
+# for saveInstanceState (e.g. PendingIntents), then we could actually keep the
+# names of just those ones. For now, we'll just keep them all.
+-keepnames class * implements android.os.Parcelable
+
+# Keep all enum values and valueOf methods. See
+# http://proguard.sourceforge.net/index.html#manual/examples.html
+# for the reason for this. Also, see http://crbug.com/248037.
+-keepclassmembers enum * {
+ public static **[] values();
+}
+
# Allows Proguard freedom in removing these log related calls. We ask for debug
# and verbose logs to be stripped out in base.Log, so we are just ensuring we
# get rid of all other debug/verbose logs.
« no previous file with comments | « base/android/base_proguard_config.flags ('k') | base/android/proguard/chromium_code.flags » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698