Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2327883002: Remove unused proguard -keep for android.webkit.JavascriptInterface (Closed)

Created:
4 years, 3 months ago by agrieve
Modified:
4 years, 3 months ago
Reviewers:
xunjieli
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused proguard -keep for android.webkit.JavascriptInterface Note: Verified that ChromePublic.apk has no change in size from this change. Also verified with codesearch that the only thing using android.webkit.JavaScriptInterface is //android_webview/test:android_webview_test_apk, which never enables proguard. BUG=645529 Committed: https://crrev.com/22a6f07769861e60b3346f94d1c09204d56604cc Cr-Commit-Position: refs/heads/master@{#417661}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M base/android/base_proguard_config.flags View 1 chunk +0 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
agrieve
On 2016/09/09 18:49:21, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:xunjieli@chromium.org
4 years, 3 months ago (2016-09-09 18:49:27 UTC) #5
xunjieli
LGTM. Thanks a lot for the CL!
4 years, 3 months ago (2016-09-09 18:51:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327883002/1
4 years, 3 months ago (2016-09-09 19:13:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 19:18:20 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:19:39 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22a6f07769861e60b3346f94d1c09204d56604cc
Cr-Commit-Position: refs/heads/master@{#417661}

Powered by Google App Engine
This is Rietveld 408576698