third_party/WebKit/Source/bindings/scripts/v8_interface.py - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_interface.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_dictionary.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_methods.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

index 623d03d975e052032f7af645161e9b1a2b64eb7f..1a471f5fa3410e9773d3054f006c4eef6bfee6e5 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_interface.py

@@ -214,7 +214,7 @@ def interface_context(interface, interfaces):

# as in the WebIDL spec?

is_immutable_prototype = is_global or 'ImmutablePrototype' in extended_attributes

- wrapper_class_id = ('NodeClassId' if inherits_interface(interface.name, 'Node') else 'ObjectClassId')

+ wrapper_class_id = ('kNodeClassId' if inherits_interface(interface.name, 'Node') else 'kObjectClassId')

# [ActiveScriptWrappable] must be accompanied with [DependentLifetime].

if active_scriptwrappable and not is_dependent_lifetime:

@@ -250,7 +250,7 @@ def interface_context(interface, interfaces):

'is_node': inherits_interface(interface.name, 'Node'),

'is_partial': interface.is_partial,

'is_typed_array_type': is_typed_array_type,

- 'lifetime': 'Dependent' if is_dependent_lifetime else 'Independent',

+ 'lifetime': 'kDependent' if is_dependent_lifetime else 'kIndependent',

'measure_as': v8_utilities.measure_as(interface, None), # [MeasureAs]

'needs_runtime_enabled_installer': needs_runtime_enabled_installer,

'origin_trial_enabled_function': v8_utilities.origin_trial_enabled_function_name(interface),

@@ -551,7 +551,7 @@ def methods_context(interface):

implemented_as=implemented_as)

if not interface.has_indexed_elements:

- iterator_method = generated_iterator_method('iterator', implemented_as='iterator')

+ iterator_method = generated_iterator_method('iterator', implemented_as='GetIterator')

if interface.iterable or interface.maplike or interface.setlike:

non_overridable_methods = []

@@ -563,12 +563,12 @@ def methods_context(interface):

# to corresponding properties in %ArrayPrototype%.

if not is_value_iterator:

non_overridable_methods.extend([

- generated_iterator_method('keys'),

- generated_iterator_method('values'),

- generated_iterator_method('entries'),

+ generated_iterator_method('Keys'),

+ generated_iterator_method('Values'),

+ generated_iterator_method('Entries'),

# void forEach(Function callback, [Default=Undefined] optional any thisArg)

- generated_method(IdlType('void'), 'forEach',

+ generated_method(IdlType('void'), 'ForEach',

arguments=[generated_argument(IdlType('Function'), 'callback'),

generated_argument(IdlType('any'), 'thisArg',

is_optional=True,

@@ -581,22 +581,22 @@ def methods_context(interface):

value_argument = generated_argument(interface.maplike.value_type, 'value')

non_overridable_methods.extend([

- generated_method(IdlType('boolean'), 'has',

+ generated_method(IdlType('boolean'), 'Has',

arguments=[key_argument],

extended_attributes=used_extended_attributes),

- generated_method(IdlType('any'), 'get',

+ generated_method(IdlType('any'), 'Get',

arguments=[key_argument],

extended_attributes=used_extended_attributes),

])

if not interface.maplike.is_read_only:

overridable_methods.extend([

- generated_method(IdlType('void'), 'clear',

+ generated_method(IdlType('void'), 'Clear',

extended_attributes=used_extended_attributes),

- generated_method(IdlType('boolean'), 'delete',

+ generated_method(IdlType('boolean'), 'Delete',

arguments=[key_argument],

extended_attributes=used_extended_attributes),

- generated_method(IdlType(interface.name), 'set',

+ generated_method(IdlType(interface.name), 'Set',

arguments=[key_argument, value_argument],

extended_attributes=used_extended_attributes),

])

@@ -605,19 +605,19 @@ def methods_context(interface):

value_argument = generated_argument(interface.setlike.value_type, 'value')

non_overridable_methods.extend([

- generated_method(IdlType('boolean'), 'has',

+ generated_method(IdlType('boolean'), 'Has',

arguments=[value_argument],

extended_attributes=used_extended_attributes),

])

if not interface.setlike.is_read_only:

overridable_methods.extend([

- generated_method(IdlType(interface.name), 'add',

+ generated_method(IdlType(interface.name), 'Add',

arguments=[value_argument],

extended_attributes=used_extended_attributes),

- generated_method(IdlType('void'), 'clear',

+ generated_method(IdlType('void'), 'Clear',

extended_attributes=used_extended_attributes),

- generated_method(IdlType('boolean'), 'delete',

+ generated_method(IdlType('boolean'), 'Delete',

arguments=[value_argument],

extended_attributes=used_extended_attributes),

])

@@ -657,7 +657,7 @@ def methods_context(interface):

serializer_ext_attrs['CallWith'] = 'ScriptState'

methods.append(generated_method(

return_type=return_type,

- name='toJSON',

+ name='ToJSON',

extended_attributes=serializer_ext_attrs,

implemented_as=implemented_as))

@@ -670,10 +670,10 @@ def methods_context(interface):

elif stringifier.operation:

implemented_as = stringifier.operation.name

else:

- implemented_as = 'toString'

+ implemented_as = 'ToString'

methods.append(generated_method(

return_type=IdlType('DOMString'),

- name='toString',

+ name='ToString',

extended_attributes=stringifier_ext_attrs,

implemented_as=implemented_as))

@@ -1037,7 +1037,7 @@ def resolution_tests_methods(effective_overloads):

try:

method = next(method for idl_type, method in idl_types_methods

if idl_type.is_nullable)

- test = 'isUndefinedOrNull(%s)' % cpp_value

+ test = 'IsUndefinedOrNull(%s)' % cpp_value

yield test, method

except StopIteration:

pass

@@ -1286,11 +1286,11 @@ def property_getter(getter, cpp_arguments):

if idl_type.use_output_parameter_for_result:

return 'result.isNull()'

if idl_type.is_string_type:

- return 'result.isNull()'

+ return 'result.IsNull()'

if idl_type.is_interface_type:

return '!result'

if idl_type.base_type in ('any', 'object'):

- return 'result.isEmpty()'

+ return 'result.IsEmpty()'

return ''

extended_attributes = getter.extended_attributes