Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_methods.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_methods.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_methods.py b/third_party/WebKit/Source/bindings/scripts/v8_methods.py
index 81263b8df8abdf0a06ad711019441f75c7c1a7e9..97f74ac844e04281d59555bbc8208cc294173cd3 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_methods.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_methods.py
@@ -322,9 +322,9 @@ def cpp_value(interface, method, number_of_arguments):
cpp_arguments.append('result')
if method.name == 'Constructor':
- base_name = 'create'
+ base_name = 'Create'
elif method.name == 'NamedConstructor':
- base_name = 'createForJSConstructor'
+ base_name = 'CreateForJSConstructor'
else:
base_name = v8_utilities.cpp_name(method)
@@ -343,7 +343,7 @@ def v8_set_return_value(interface_name, method, cpp_value, for_main_world=False)
if use_local_result(method):
if idl_type.is_explicit_nullable:
# result is of type Nullable<T>
- cpp_value = 'result.get()'
+ cpp_value = 'result.Get()'
else:
cpp_value = 'result'
@@ -362,8 +362,8 @@ def v8_value_to_local_cpp_variadic_value(method, argument, index, return_promise
vector_type = 'Vector'
return {
- 'assign_expression': 'toImplArguments<%s<%s>>(info, %s, exceptionState)' % (vector_type, this_cpp_type, index),
- 'check_expression': 'exceptionState.hadException()',
+ 'assign_expression': 'ToImplArguments<%s<%s>>(info, %s, exceptionState)' % (vector_type, this_cpp_type, index),
+ 'check_expression': 'exceptionState.HadException()',
'cpp_type': this_cpp_type,
'cpp_name': argument.name,
'declare_variable': False,
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_interface.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_types.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698