Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/scripts/v8_dictionary.py
diff --git a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py
index 14af42f00089bedabc542cf66bb3c4a007a3f44a..66fd18f16b8a15670edca090456ee14441e40cb3 100644
--- a/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py
+++ b/third_party/WebKit/Source/bindings/scripts/v8_dictionary.py
@@ -209,12 +209,14 @@ def member_impl_context(member, interfaces_info, header_includes,
def has_method_expression():
if nullable_indicator_name:
return nullable_indicator_name
- elif idl_type.is_enum or idl_type.is_string_type or idl_type.is_union_type:
+ elif idl_type.is_union_type:
return '!m_%s.isNull()' % cpp_name
+ elif idl_type.is_enum or idl_type.is_string_type:
+ return '!m_%s.IsNull()' % cpp_name
elif idl_type.name in ['Any', 'Object']:
- return '!(m_{0}.isEmpty() || m_{0}.isNull() || m_{0}.isUndefined())'.format(cpp_name)
+ return '!(m_{0}.IsEmpty() || m_{0}.IsNull() || m_{0}.IsUndefined())'.format(cpp_name)
elif idl_type.name == 'Dictionary':
- return '!m_%s.isUndefinedOrNull()' % cpp_name
+ return '!m_%s.IsUndefinedOrNull()' % cpp_name
else:
return 'm_%s' % cpp_name

Powered by Google App Engine
This is Rietveld 408576698