third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py - Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)

Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_callback_function.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py b/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

index 524972196b1922f178d039edd2074f165e42df07..a3f97e73a56fff896c244fc2858ef73ab73c1183 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

@@ -116,8 +116,8 @@ def arguments_context(arguments, call_with_this_handle):

return {

'handle': '%sHandle' % argument.name,

'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(

- argument.name, isolate='m_scriptState->isolate()',

- creation_context='m_scriptState->context()->Global()'),

+ argument.name, isolate='m_scriptState->GetIsolate()',

+ creation_context='m_scriptState->GetContext()->Global()'),

}

argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle else []