Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: third_party/WebKit/Source/bindings/scripts/v8_callback_interface.py

Issue 2329463004: ABANDONED CL: Changes needed to make things compile after running rewrite_to_chrome_style tool. (Closed)
Patch Set: More fixes - things build fine at this point. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # 2 #
3 # Redistribution and use in source and binary forms, with or without 3 # Redistribution and use in source and binary forms, with or without
4 # modification, are permitted provided that the following conditions are 4 # modification, are permitted provided that the following conditions are
5 # met: 5 # met:
6 # 6 #
7 # * Redistributions of source code must retain the above copyright 7 # * Redistributions of source code must retain the above copyright
8 # notice, this list of conditions and the following disclaimer. 8 # notice, this list of conditions and the following disclaimer.
9 # * Redistributions in binary form must reproduce the above 9 # * Redistributions in binary form must reproduce the above
10 # copyright notice, this list of conditions and the following disclaimer 10 # copyright notice, this list of conditions and the following disclaimer
(...skipping 98 matching lines...) Expand 10 before | Expand all | Expand 10 after
109 context.update(arguments_context(operation.arguments, 109 context.update(arguments_context(operation.arguments,
110 call_with_this_handle)) 110 call_with_this_handle))
111 return context 111 return context
112 112
113 113
114 def arguments_context(arguments, call_with_this_handle): 114 def arguments_context(arguments, call_with_this_handle):
115 def argument_context(argument): 115 def argument_context(argument):
116 return { 116 return {
117 'handle': '%sHandle' % argument.name, 117 'handle': '%sHandle' % argument.name,
118 'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value( 118 'cpp_value_to_v8_value': argument.idl_type.cpp_value_to_v8_value(
119 argument.name, isolate='m_scriptState->isolate()', 119 argument.name, isolate='m_scriptState->GetIsolate()',
120 creation_context='m_scriptState->context()->Global()'), 120 creation_context='m_scriptState->GetContext()->Global()'),
121 } 121 }
122 122
123 argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle e lse [] 123 argument_declarations = ['ScriptValue thisValue'] if call_with_this_handle e lse []
124 argument_declarations.extend( 124 argument_declarations.extend(
125 '%s %s' % (argument.idl_type.callback_cpp_type, argument.name) 125 '%s %s' % (argument.idl_type.callback_cpp_type, argument.name)
126 for argument in arguments) 126 for argument in arguments)
127 return { 127 return {
128 'argument_declarations': argument_declarations, 128 'argument_declarations': argument_declarations,
129 'arguments': [argument_context(argument) for argument in arguments], 129 'arguments': [argument_context(argument) for argument in arguments],
130 } 130 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698