[MD Extensions] Implement opening tab-style options pages

[MD Extensions] Implement opening tab-style options pages

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b2818ed32855718f2331f91f5072f711be2d51e3
Cr-Commit-Position: refs/heads/master@{#419004}

[Devlin, 2016-09-10 00:57:10]

Description was changed from

==========
[MD Extensions] Implement opening tab-style options pages

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
==========

to

==========
[MD Extensions] Implement opening tab-style options pages

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Devlin, 2016-09-10 00:57:13]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 00:57:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 01:04:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 01:04:34]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Devlin, 2016-09-12 16:36:05]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[Devlin, 2016-09-12 16:36:34]

rdevlin.cronin@chromium.org changed reviewers:
+ michaelpg@chromium.org

[Devlin, 2016-09-12 16:36:34]

Heya Michael, mind taking a look when you're back?

[commit-bot: I haz the power, 2016-09-12 16:36:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 17:58:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 17:58:49]

Dry run: This issue passed the CQ dry run.

[michaelpg, 2016-09-15 02:13:46]

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_extensions/detail_view.html (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.html:65:
on-click="onCloseButtonClick_"></paper-icon-button>
on-tap

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.html:70:
on-click="onOptionsButtonClick_"
on-tap

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_detail_view_test.js (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:107: var
optionsUrl = 'chrome-extension://' + item.data.id + '/options.html';
extensionData.id for consistency with other tests?

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:109:
Polymer.dom.flush();
why is this needed?

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:114: var
optionsUrl = 'chrome-extension://' + item.data.id + '/options.html';
extensionData.id for consistency with other tests?

[Devlin, 2016-09-15 16:42:17]

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
File chrome/browser/resources/md_extensions/detail_view.html (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.html:65:
on-click="onCloseButtonClick_"></paper-icon-button>
On 2016/09/15 02:13:46, michaelpg wrote:
> on-tap

Done.

https://codereview.chromium.org/2329443004/diff/20001/chrome/browser/resource...
chrome/browser/resources/md_extensions/detail_view.html:70:
on-click="onOptionsButtonClick_"
On 2016/09/15 02:13:46, michaelpg wrote:
> on-tap

Done.

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_detail_view_test.js (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:107: var
optionsUrl = 'chrome-extension://' + item.data.id + '/options.html';
On 2016/09/15 02:13:46, michaelpg wrote:
> extensionData.id for consistency with other tests?

Done.

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:109:
Polymer.dom.flush();
On 2016/09/15 02:13:46, michaelpg wrote:
> why is this needed?

I thought we needed to flush after using set().  Apparently we don't.  Removed.

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:114: var
optionsUrl = 'chrome-extension://' + item.data.id + '/options.html';
On 2016/09/15 02:13:46, michaelpg wrote:
> extensionData.id for consistency with other tests?

Done.

[michaelpg, 2016-09-15 20:56:27]

lgtm

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_detail_view_test.js (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:109:
Polymer.dom.flush();
On 2016/09/15 16:42:17, Devlin wrote:
> On 2016/09/15 02:13:46, michaelpg wrote:
> > why is this needed?
> 
> I thought we needed to flush after using set().  Apparently we don't. 
Removed.

nope, data binding is almost always synchronous. But a flush would be necessary
if there were a <template is="dom-if"> that depended on this property, for
example, because the template stamps asynchronously.

[Devlin, 2016-09-15 21:01:50]

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/extensions/extension_detail_view_test.js (right):

https://codereview.chromium.org/2329443004/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/extensions/extension_detail_view_test.js:109:
Polymer.dom.flush();
On 2016/09/15 20:56:26, michaelpg wrote:
> On 2016/09/15 16:42:17, Devlin wrote:
> > On 2016/09/15 02:13:46, michaelpg wrote:
> > > why is this needed?
> > 
> > I thought we needed to flush after using set().  Apparently we don't. 
> Removed.
> 
> nope, data binding is almost always synchronous. But a flush would be
necessary
> if there were a <template is="dom-if"> that depended on this property, for
> example, because the template stamps asynchronously.

Ah, that clears up a lot of the mystery of when to use this. :)  Thanks!

[Devlin, 2016-09-15 21:02:02]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-09-15 21:03:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 22:07:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-15 22:10:48]

Description was changed from

==========
[MD Extensions] Implement opening tab-style options pages

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Extensions] Implement opening tab-style options pages

Add logic to open options pages that open in tabs (embedded options
pages still to come). Add a test for the same.

BUG=529395
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b2818ed32855718f2331f91f5072f711be2d51e3
Cr-Commit-Position: refs/heads/master@{#419004}
==========

[commit-bot: I haz the power, 2016-09-15 22:10:50]

Patchset 3 (id:??) landed as
https://crrev.com/b2818ed32855718f2331f91f5072f711be2d51e3
Cr-Commit-Position: refs/heads/master@{#419004}