Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: chrome/browser/resources/md_extensions/service.js

Issue 2329443004: [MD Extensions] Implement opening tab-style options pages (Closed)
Patch Set: Michael's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/service.js
diff --git a/chrome/browser/resources/md_extensions/service.js b/chrome/browser/resources/md_extensions/service.js
index 0482a574cfccf26d0b04a259130be0b75818ab4e..d14cbda360647a834b431182df01395c3689af59 100644
--- a/chrome/browser/resources/md_extensions/service.js
+++ b/chrome/browser/resources/md_extensions/service.js
@@ -216,6 +216,17 @@ cr.define('extensions', function() {
},
/** @override */
+ showItemOptionsPage: function(id) {
+ var extension = this.extensions_.find(function(extension) {
+ return extension.id == id;
+ });
+ assert(extension && extension.optionsPage);
+ if (extension.optionsPage.openInTab)
+ chrome.developerPrivate.showOptions(id);
+ // TODO(devlin): Handle embedded extension options.
+ },
+
+ /** @override */
setProfileInDevMode: function(inDevMode) {
chrome.developerPrivate.updateProfileConfiguration(
{inDeveloperMode: inDevMode});
« no previous file with comments | « chrome/browser/resources/md_extensions/item.js ('k') | chrome/test/data/webui/extensions/extension_detail_view_test.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698