Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: chrome/browser/resources/md_extensions/detail_view.js

Issue 2329443004: [MD Extensions] Implement opening tab-style options pages (Closed)
Patch Set: Michael's Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/md_extensions/detail_view.js
diff --git a/chrome/browser/resources/md_extensions/detail_view.js b/chrome/browser/resources/md_extensions/detail_view.js
index c3b0afd930c0f76fdf6ebdb92ee0ab234da9d677..fb4323a4fb062413c4cea71e431da2ab6c9cde8c 100644
--- a/chrome/browser/resources/md_extensions/detail_view.js
+++ b/chrome/browser/resources/md_extensions/detail_view.js
@@ -28,7 +28,7 @@ cr.define('extensions', function() {
},
/** @private */
- onCloseButtonClick_: function() {
+ onCloseButtonTap_: function() {
this.fire('close');
},
@@ -52,6 +52,14 @@ cr.define('extensions', function() {
* @return {boolean}
* @private
*/
+ shouldShowOptionsButton_: function() {
+ return !!this.data.optionsPage;
+ },
+
+ /**
+ * @return {boolean}
+ * @private
+ */
shouldShowOptionsSection_: function() {
return this.data.incognitoAccess.isEnabled ||
this.data.fileAccess.isEnabled ||
@@ -60,6 +68,11 @@ cr.define('extensions', function() {
},
/** @private */
+ onOptionsButtonTap_: function() {
+ this.delegate.showItemOptionsPage(this.data.id);
+ },
+
+ /** @private */
onAllowIncognitoChange_: function() {
this.delegate.setItemAllowedIncognito(
this.data.id, this.$$('#allow-incognito').checked);
« no previous file with comments | « chrome/browser/resources/md_extensions/detail_view.html ('k') | chrome/browser/resources/md_extensions/item.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698