Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2329433003: Revert of [ash-md] Fades overview header in and out (Closed)

Created:
4 years, 3 months ago by dmurph
Modified:
4 years, 3 months ago
Reviewers:
varkha, sky, bruthig
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [ash-md] Fades overview header in and out (patchset #17 id:400001 of https://codereview.chromium.org/2239233002/ ) Reason for revert: This is causing a use-after-free and crashing stuff :( BUG=645708 Original issue's description: > [ash-md] Fades overview header in and out > > This change installs an additional header on top of the real window's header and animates its bounds and opacity such that it appears to take over the real header. Only once the "fake" header is opaque a mask or alpha shape is applied to the window to hide its original header after which the "fake" header becomes translucent to conform to MD overview mode spec. > > This creates a visually smoother transition into overview mode than before. > > Special care is taken to animate the "fake" header in case when the window is restored for the overview mode from the minimized state and is thus animated from the shelf item. > > BUG=624608, 645076 > TEST=Most changes are only really visible under a great slow-down but watching closely the files app header transform into overview mode should be much less abrupt. > > Committed: https://crrev.com/f5d0098acc9a8167409476627eae3e91d94e8cac > Cr-Commit-Position: refs/heads/master@{#417728} TBR=sky@chromium.org,bruthig@chromium.org,varkha@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=624608, 645076 Committed: https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0 Cr-Commit-Position: refs/heads/master@{#417796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -706 lines) Patch
M ash/aura/wm_window_aura.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/aura/wm_window_aura.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M ash/common/frame/custom_frame_view_ash.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/frame/default_header_painter.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/frame/default_header_painter.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/frame/header_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ash/common/frame/header_view.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ash/common/wm/overview/overview_animation_type.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/common/wm/overview/scoped_overview_animation_settings.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.h View 5 chunks +9 lines, -18 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 7 chunks +37 lines, -59 lines 0 comments Download
M ash/common/wm/overview/window_grid.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/common/wm/overview/window_grid.cc View 7 chunks +31 lines, -36 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 11 chunks +7 lines, -52 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 23 chunks +124 lines, -346 lines 0 comments Download
M ash/common/wm_window.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/common/wm_window_property.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.h View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/mus/bridge/wm_window_mus.cc View 2 chunks +0 lines, -27 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_aura.h View 2 chunks +2 lines, -8 lines 0 comments Download
M ash/wm/overview/scoped_overview_animation_settings_aura.cc View 4 chunks +21 lines, -43 lines 0 comments Download
M ash/wm/overview/window_selector_unittest.cc View 17 chunks +8 lines, -35 lines 0 comments Download
M ash/wm/panels/panel_frame_view.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_non_client_frame_view_ash.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/aura/client/aura_constants.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/aura/client/aura_constants.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dmurph
Created Revert of [ash-md] Fades overview header in and out
4 years, 3 months ago (2016-09-10 01:49:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329433003/1
4 years, 3 months ago (2016-09-10 01:49:54 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-10 01:51:35 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-10 01:56:08 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/758e34e4a30be65c2cedf5fb2a893fa3a87596f0
Cr-Commit-Position: refs/heads/master@{#417796}

Powered by Google App Engine
This is Rietveld 408576698