Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 232933003: Revert r20652 "Handlify and convert string.length to new API-style accessor." (Closed)

Created:
6 years, 8 months ago by ulan
Modified:
6 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Visibility:
Public.

Description

Revert r20652 "Handlify and convert string.length to new API-style accessor." Reason: test failure with --noenable-sse3. R=dcarney@chromium.org TBR=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20653

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -90 lines) Patch
M src/accessors.h View 4 chunks +2 lines, -22 lines 0 comments Download
M src/accessors.cc View 2 chunks +14 lines, -54 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ulan
PTAL
6 years, 8 months ago (2014-04-10 12:38:16 UTC) #1
dcarney
lgtm
6 years, 8 months ago (2014-04-10 12:40:12 UTC) #2
ulan
6 years, 8 months ago (2014-04-10 12:41:05 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20653 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698