src/bootstrapper.cc - Issue 232933003: Revert r20652 "Handlify and convert string.length to new API-style accessor."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/bootstrapper.cc

Issue 232933003: Revert r20652 "Handlify and convert string.length to new API-style accessor." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/bootstrapper.cc

diff --git a/src/bootstrapper.cc b/src/bootstrapper.cc

index 35f8869b7ce1f6aeb3b748920f5d4c6c6159c078..4cfebadd57bf27daceb15f1990d171781f75a5e9 100644

--- a/src/bootstrapper.cc

+++ b/src/bootstrapper.cc

@@ -920,10 +920,10 @@ void Genesis::InitializeGlobal(Handle<GlobalObject> inner_global,

factory->NewDescriptorArray(0, 1));

DescriptorArray::WhitenessWitness witness(*string_descriptors);

+ Handle<Foreign> string_length(

+ factory->NewForeign(&Accessors::StringLength));

PropertyAttributes attribs = static_cast<PropertyAttributes>(

DONT_ENUM | DONT_DELETE | READ_ONLY);

- Handle<AccessorInfo> string_length(

- Accessors::StringLengthInfo(isolate, attribs));

string_map->set_instance_descriptors(*string_descriptors);

{ // Add length.

« no previous file with comments | « src/accessors.cc ('k') | src/serialize.cc » ('j') | no next file with comments »