Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/serialize.cc

Issue 232933003: Revert r20652 "Handlify and convert string.length to new API-style accessor." (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/bootstrapper.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 Add(isolate->get_address_from_id((Isolate::AddressId)i), 269 Add(isolate->get_address_from_id((Isolate::AddressId)i),
270 TOP_ADDRESS, i, AddressNames[i]); 270 TOP_ADDRESS, i, AddressNames[i]);
271 } 271 }
272 272
273 // Accessors 273 // Accessors
274 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \ 274 #define ACCESSOR_DESCRIPTOR_DECLARATION(name) \
275 Add((Address)&Accessors::name, \ 275 Add((Address)&Accessors::name, \
276 ACCESSOR, \ 276 ACCESSOR, \
277 Accessors::k##name, \ 277 Accessors::k##name, \
278 "Accessors::" #name); 278 "Accessors::" #name);
279
279 ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION) 280 ACCESSOR_DESCRIPTOR_LIST(ACCESSOR_DESCRIPTOR_DECLARATION)
280 #undef ACCESSOR_DESCRIPTOR_DECLARATION 281 #undef ACCESSOR_DESCRIPTOR_DECLARATION
281 282
282 #define ACCESSOR_INFO_DECLARATION(name) \
283 Add(FUNCTION_ADDR(&Accessors::name##Getter), \
284 ACCESSOR, \
285 Accessors::k##name##Getter, \
286 "Accessors::" #name "Getter"); \
287 Add(FUNCTION_ADDR(&Accessors::name##Setter), \
288 ACCESSOR, \
289 Accessors::k##name##Setter, \
290 "Accessors::" #name "Setter");
291 ACCESSOR_INFO_LIST(ACCESSOR_INFO_DECLARATION)
292 #undef ACCESSOR_INFO_DECLARATION
293
294 StubCache* stub_cache = isolate->stub_cache(); 283 StubCache* stub_cache = isolate->stub_cache();
295 284
296 // Stub cache tables 285 // Stub cache tables
297 Add(stub_cache->key_reference(StubCache::kPrimary).address(), 286 Add(stub_cache->key_reference(StubCache::kPrimary).address(),
298 STUB_CACHE_TABLE, 287 STUB_CACHE_TABLE,
299 1, 288 1,
300 "StubCache::primary_->key"); 289 "StubCache::primary_->key");
301 Add(stub_cache->value_reference(StubCache::kPrimary).address(), 290 Add(stub_cache->value_reference(StubCache::kPrimary).address(),
302 STUB_CACHE_TABLE, 291 STUB_CACHE_TABLE,
303 2, 292 2,
(...skipping 1583 matching lines...) Expand 10 before | Expand all | Expand 10 after
1887 1876
1888 bool SnapshotByteSource::AtEOF() { 1877 bool SnapshotByteSource::AtEOF() {
1889 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false; 1878 if (0u + length_ - position_ > 2 * sizeof(uint32_t)) return false;
1890 for (int x = position_; x < length_; x++) { 1879 for (int x = position_; x < length_; x++) {
1891 if (data_[x] != SerializerDeserializer::nop()) return false; 1880 if (data_[x] != SerializerDeserializer::nop()) return false;
1892 } 1881 }
1893 return true; 1882 return true;
1894 } 1883 }
1895 1884
1896 } } // namespace v8::internal 1885 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/bootstrapper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698