|
|
Created:
4 years, 3 months ago by sadrul Modified:
4 years, 3 months ago Reviewers:
Fady Samuel CC:
chromium-reviews, rjkroege, piman+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionservices/ui: Avoid thread hopping in the gpu process.
Bind the GpuServiceInternal request on the gpu thread, instead of in the
main thread. This means it is possible to service a request from the host
without thread hopping between the main and gpu threads.
BUG=643746
Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58
Committed: https://crrev.com/08f982ad2a3cf6d5b0ce5fc7326e01b3f6073b10
Cr-Original-Commit-Position: refs/heads/master@{#418275}
Cr-Commit-Position: refs/heads/master@{#418468}
Patch Set 1 #Patch Set 2 : tot merge #Patch Set 3 : . #Patch Set 4 : fix debug #
Messages
Total messages: 42 (29 generated)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sadrul@chromium.org changed reviewers: + fsamuel@chromium.org
Hooray! Thanks for making the world a better place! LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org Link to the patchset: https://codereview.chromium.org/2329043002/#ps20001 (title: "tot merge")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sadrul@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org Link to the patchset: https://codereview.chromium.org/2329043002/#ps40001 (title: ".")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 ========== to ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275}
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2339653002/ by sadrul@chromium.org. The reason for reverting is: mus_ws_unittests on linux debug builders are crashing: [11191:11245:0913/111107:210172940:FATAL:lock_impl_posix.cc(65)] Check failed: rv == 0 (22 vs. 0). Invalid argument #0 0x7f806072969e base::debug::StackTrace::StackTrace() #1 0x7f806079332f logging::LogMessage::~LogMessage() #2 0x7f806089106d base::internal::LockImpl::Lock() #3 0x7f80606f9d23 base::Lock::Acquire() #4 0x7f80606f99c3 base::AutoLock::AutoLock() #5 0x7f8060857364 base::SequenceCheckerImpl::CalledOnValidSequence() #6 0x000000660eba base::Thread::task_runner() #7 0x0000006606b2 ui::GpuServiceInternal::Initialize() #8 0x0000006a14f0 ui::mojom::GpuServiceInternalStub::AcceptWithResponder() ....
Message was sent while issue was closed.
Description was changed from ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ========== to ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ==========
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by sadrul@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sadrul@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org Link to the patchset: https://codereview.chromium.org/2329043002/#ps80001 (title: "fix debug")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ========== to ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ==========
Message was sent while issue was closed.
Committed patchset #4 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275} ========== to ========== services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Committed: https://crrev.com/08f982ad2a3cf6d5b0ce5fc7326e01b3f6073b10 Cr-Original-Commit-Position: refs/heads/master@{#418275} Cr-Commit-Position: refs/heads/master@{#418468} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/08f982ad2a3cf6d5b0ce5fc7326e01b3f6073b10 Cr-Commit-Position: refs/heads/master@{#418468} |