Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 2329043002: services/ui: Avoid thread hopping in the gpu process. (Closed)

Created:
4 years, 3 months ago by sadrul
Modified:
4 years, 3 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

services/ui: Avoid thread hopping in the gpu process. Bind the GpuServiceInternal request on the gpu thread, instead of in the main thread. This means it is possible to service a request from the host without thread hopping between the main and gpu threads. BUG=643746 Committed: https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Committed: https://crrev.com/08f982ad2a3cf6d5b0ce5fc7326e01b3f6073b10 Cr-Original-Commit-Position: refs/heads/master@{#418275} Cr-Commit-Position: refs/heads/master@{#418468}

Patch Set 1 #

Patch Set 2 : tot merge #

Patch Set 3 : . #

Patch Set 4 : fix debug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -107 lines) Patch
M services/ui/gpu/gpu_service_internal.h View 3 chunks +2 lines, -23 lines 0 comments Download
M services/ui/gpu/gpu_service_internal.cc View 1 2 3 9 chunks +49 lines, -84 lines 0 comments Download

Messages

Total messages: 42 (29 generated)
sadrul
4 years, 3 months ago (2016-09-09 20:43:23 UTC) #4
Fady Samuel
Hooray! Thanks for making the world a better place! LGTM
4 years, 3 months ago (2016-09-09 20:45:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329043002/20001
4 years, 3 months ago (2016-09-12 22:23:18 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/296276)
4 years, 3 months ago (2016-09-12 23:39:40 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329043002/20001
4 years, 3 months ago (2016-09-13 14:31:31 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/296654)
4 years, 3 months ago (2016-09-13 15:44:00 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329043002/40001
4 years, 3 months ago (2016-09-13 16:47:20 UTC) #25
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-09-13 16:52:25 UTC) #26
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/9894bae5c1e1f03ab2b14f7b2325296587002a58 Cr-Commit-Position: refs/heads/master@{#418275}
4 years, 3 months ago (2016-09-13 16:55:21 UTC) #28
sadrul
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2339653002/ by sadrul@chromium.org. ...
4 years, 3 months ago (2016-09-13 19:49:47 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2329043002/80001
4 years, 3 months ago (2016-09-14 03:00:07 UTC) #38
commit-bot: I haz the power
Committed patchset #4 (id:80001)
4 years, 3 months ago (2016-09-14 03:05:12 UTC) #40
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 03:08:04 UTC) #42
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/08f982ad2a3cf6d5b0ce5fc7326e01b3f6073b10
Cr-Commit-Position: refs/heads/master@{#418468}

Powered by Google App Engine
This is Rietveld 408576698