Remove more blink modules gypi code.

Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.

Committed: https://crrev.com/0a91363934d878f3cd10aed2b4caf6fe239ec571
Cr-Commit-Position: refs/heads/master@{#417667}

[brettw, 2016-09-08 21:20:49]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[brettw, 2016-09-08 21:21:03]

brettw@chromium.org changed reviewers:
+ haraken@chromium.org

[commit-bot: I haz the power, 2016-09-08 21:21:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[brettw, 2016-09-08 22:29:03]

Description was changed from

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.
==========

to

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.
==========

[commit-bot: I haz the power, 2016-09-08 23:26:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:26:19]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-08 23:44:25]

LGTM

https://codereview.chromium.org/2328773002/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/modules_idl_files.gni (right):

https://codereview.chromium.org/2328773002/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/modules_idl_files.gni:597: # different
categories of .idl files that prodice certain patterns of

produce

[brettw, 2016-09-09 17:19:18]

Selling correction

[brettw, 2016-09-09 17:19:19]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-09-09 17:19:20]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2328773002/#ps20001
(title: "Selling correction")

[commit-bot: I haz the power, 2016-09-09 17:19:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:33:31]

Description was changed from

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.
==========

to

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.
==========

[commit-bot: I haz the power, 2016-09-09 19:33:32]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-09 19:35:15]

Description was changed from

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.
==========

to

==========
Remove more blink modules gypi code.

Improves the templates for make_names and process_in_files so they can be used
in a few more situations (not automatically inserting deps), clean up callers
that were manually calling these.

Add a new target bindings/modules:generated which compiles the sources
generated by the scripts in that file. This eliminates the hardcoding of these
source lists.

With this, the only remaining blink work should be to move the rest of the
source files into the modules sub-directories.

Committed: https://crrev.com/0a91363934d878f3cd10aed2b4caf6fe239ec571
Cr-Commit-Position: refs/heads/master@{#417667}
==========

[commit-bot: I haz the power, 2016-09-09 19:35:16]

Patchset 2 (id:??) landed as
https://crrev.com/0a91363934d878f3cd10aed2b4caf6fe239ec571
Cr-Commit-Position: refs/heads/master@{#417667}

[dtu, 2016-09-09 20:25:43]

Hey, seeing a failure on the Win x64 Perf bot:
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/build...

C:\b\c\b\Win_x64_Builder\src\buildtools\win\gn.exe gen //out/Release_x64 --check
  -> returned 1
ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
      static_library(current_name) {
      ^-----------------------------
The item //third_party/WebKit/Source/modules:modules_0
can not depend on //third_party/WebKit/Source/bindings/modules:generated
because it is not in //third_party/WebKit/Source/bindings/modules:generated's
visibility list: [
  //third_party/WebKit/Source/modules:modules
]
GN gen failed: 1

[agable, 2016-09-09 21:24:32]

On 2016/09/09 at 20:25:43, dtu wrote:
> Hey, seeing a failure on the Win x64 Perf bot:
>
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder/build...
> 
> C:\b\c\b\Win_x64_Builder\src\buildtools\win\gn.exe gen //out/Release_x64
--check
>   -> returned 1
> ERROR at //build/split_static_library.gni:27:7: Dependency not allowed.
>       static_library(current_name) {
>       ^-----------------------------
> The item //third_party/WebKit/Source/modules:modules_0
> can not depend on //third_party/WebKit/Source/bindings/modules:generated
> because it is not in //third_party/WebKit/Source/bindings/modules:generated's
visibility list: [
>   //third_party/WebKit/Source/modules:modules
> ]
> GN gen failed: 1

Yep, this CL is definitely breaking things. Tracking here:
https://bugs.chromium.org/p/chromium/issues/detail?id=645621

[dmurph, 2016-09-10 01:35:09]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2328033002/ by dmurph@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=645621
BUG=645621.