Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 2324803006: Move more sources from modules.gypi to subdirectories. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dominickn+watch_chromium.org, dshwang, eric.carlson_apple.com, scheib+watch_chromium.org, ortuno+watch_chromium.org, dmazzoni+watch_chromium.org, je_julie, Srirama, aboxhall, aboxhall+watch_chromium.org, chasej+watch_chromium.org, Justin Novosad, Rik, jkarlin+watch_chromium.org, blink-reviews, ajuma+watch-canvas_chromium.org, Peter Beverloo, timvolodine, feature-media-reviews_chromium.org, dmazzoni, yuzo+watch_chromium.org, haraken, mlamouri+watch-blink_chromium.org, nektar+watch_chromium.org, iclelland+watch_chromium.org, nektarios, dtseng+watch_chromium.org, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move more sources from modules.gypi to subdirectories. More classes of Blink modules are moved from the deprecated modules.gypi to separate BUILD files in the module directories. TBR=dpranke@chromium.org Committed: https://crrev.com/9ce4e475c115bd1e473bb02f6cab81d767586ac9 Cr-Commit-Position: refs/heads/master@{#417700}

Patch Set 1 #

Patch Set 2 : gn check #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -343 lines) Patch
M third_party/WebKit/Source/modules/BUILD.gn View 1 1 chunk +22 lines, -1 line 0 comments Download
A third_party/WebKit/Source/modules/accessibility/BUILD.gn View 1 chunk +68 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/app_banner/BUILD.gn View 1 chunk +18 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/audio_output_devices/BUILD.gn View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/background_sync/BUILD.gn View 1 chunk +21 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/battery/BUILD.gn View 1 1 chunk +21 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/beacon/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/bluetooth/BUILD.gn View 1 chunk +30 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/broadcastchannel/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/budget/BUILD.gn View 1 chunk +9 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/cachestorage/BUILD.gn View 1 chunk +20 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/canvas/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/canvas2d/BUILD.gn View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/compositorworker/BUILD.gn View 1 chunk +28 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/credentialmanager/BUILD.gn View 1 chunk +24 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/crypto/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/csspaint/BUILD.gn View 1 chunk +23 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/device_light/BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/device_orientation/BUILD.gn View 1 chunk +34 lines, -0 lines 0 comments Download
A + third_party/WebKit/Source/modules/donottrack/BUILD.gn View 1 chunk +3 lines, -3 lines 0 comments Download
A + third_party/WebKit/Source/modules/encoding/BUILD.gn View 1 chunk +7 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/modules/encryptedmedia/BUILD.gn View 1 chunk +35 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/modules/fetch/BUILD.gn View 1 chunk +54 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 chunk +0 lines, -321 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
brettw
gn check
4 years, 3 months ago (2016-09-09 18:31:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324803006/20001
4 years, 3 months ago (2016-09-09 19:45:16 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-09 20:55:32 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/9ce4e475c115bd1e473bb02f6cab81d767586ac9 Cr-Commit-Position: refs/heads/master@{#417700}
4 years, 3 months ago (2016-09-09 20:58:44 UTC) #15
dmurph
4 years, 3 months ago (2016-09-10 01:34:36 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2332493002/ by dmurph@chromium.org.

The reason for reverting is:
https://bugs.chromium.org/p/chromium/issues/detail?id=645621
BUG=645621.

Powered by Google App Engine
This is Rietveld 408576698