Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: third_party/WebKit/Source/modules/modules.gni

Issue 2328773002: Remove more blink modules gypi code. (Closed)
Patch Set: Selling correction Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/modules.gni
diff --git a/third_party/WebKit/Source/modules/modules.gni b/third_party/WebKit/Source/modules/modules.gni
index 9a9f01a73a9e065c16b31c65521671edb41006b4..5961dc3040f1540544b8b26c6f93bf844c54289d 100644
--- a/third_party/WebKit/Source/modules/modules.gni
+++ b/third_party/WebKit/Source/modules/modules.gni
@@ -2,6 +2,11 @@
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
+# DON'T INCLUDE modules_idl_files.gni FROM HERE.
+#
+# This file is shared with all modules' BUILD files which shouldn't need access
+# to the huge and slow lists of sources. If sharing is necessary, make a
+# separate .gni.
import("//third_party/WebKit/Source/config.gni")
_gypi = exec_script(
@@ -13,25 +18,7 @@ _gypi = exec_script(
],
"scope",
[ "modules.gypi" ])
-
-# interfaces that inherit from Event
-generated_modules_files =
- get_path_info(_gypi.generated_modules_files, "abspath")
-
-generated_modules_dictionary_files =
- get_path_info(_gypi.generated_modules_dictionary_files, "abspath")
-
-# Remove GYP variables from the list (need to do this before rebasing).
-_tmp_modules_files = _gypi.modules_files
-_tmp_modules_files -= [
- "<@(extra_blink_module_files)",
- "<@(generated_modules_dictionary_files)",
- "<@(generated_modules_files)",
-]
-modules_files = get_path_info(_tmp_modules_files, "abspath")
-
-# Account for GYP var expansion.
-modules_files += generated_modules_files + generated_modules_dictionary_files
+modules_files = get_path_info(_gypi.modules_files, "abspath")
# Defines a part of blink modules. This is either a source set or a static
# library with defaults for commonly-used values.
« no previous file with comments | « third_party/WebKit/Source/modules/BUILD.gn ('k') | third_party/WebKit/Source/modules/modules.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698