Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2328693002: Updated linter with upstream release (2.3.19) (Closed)

Created:
4 years, 3 months ago by The one and only Dr. Crash
Modified:
4 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, vitalyp+closure_chromium.org, jlklein+watch-closure_chromium.org, dbeam+watch-closure_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Updated linted with upstream release (2.3.19) BUG=639691 TEST=tests in upstream distribution Committed: https://crrev.com/d61c8a2443b4fad17823e470c4fe3eea133b172e Cr-Commit-Position: refs/heads/master@{#417426}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2185 lines, -421 lines) Patch
M third_party/closure_linter/README View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/closure_linter/README.chromium View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/closure_linter/closure_linter/aliaspass.py View 4 chunks +44 lines, -18 lines 0 comments Download
M third_party/closure_linter/closure_linter/aliaspass_test.py View 3 chunks +31 lines, -2 lines 0 comments Download
M third_party/closure_linter/closure_linter/checker.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/closurizednamespacesinfo.py View 13 chunks +137 lines, -45 lines 0 comments Download
M third_party/closure_linter/closure_linter/closurizednamespacesinfo_test.py View 17 chunks +283 lines, -12 lines 0 comments Download
M third_party/closure_linter/closure_linter/common/filetestcase.py View 2 chunks +7 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/ecmalintrules.py View 14 chunks +114 lines, -65 lines 0 comments Download
M third_party/closure_linter/closure_linter/ecmametadatapass.py View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/closure_linter/closure_linter/error_check.py View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/error_fixer.py View 6 chunks +126 lines, -36 lines 0 comments Download
M third_party/closure_linter/closure_linter/error_fixer_test.py View 2 chunks +20 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/errors.py View 4 chunks +8 lines, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/fixjsstyle.py View 3 chunks +9 lines, -1 line 1 comment Download
M third_party/closure_linter/closure_linter/fixjsstyle_test.py View 2 chunks +215 lines, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/full_test.py View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/gjslint.py View 1 chunk +8 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/indentation.py View 9 chunks +72 lines, -36 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascriptlintrules.py View 15 chunks +69 lines, -57 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascriptstatetracker.py View 2 chunks +2 lines, -9 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascripttokenizer.py View 11 chunks +122 lines, -17 lines 0 comments Download
M third_party/closure_linter/closure_linter/javascripttokens.py View 4 chunks +15 lines, -5 lines 0 comments Download
M third_party/closure_linter/closure_linter/requireprovidesorter.py View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/scopeutil.py View 3 chunks +52 lines, -18 lines 0 comments Download
M third_party/closure_linter/closure_linter/scopeutil_test.py View 1 chunk +26 lines, -14 lines 0 comments Download
M third_party/closure_linter/closure_linter/statetracker.py View 15 chunks +107 lines, -24 lines 0 comments Download
M third_party/closure_linter/closure_linter/statetracker_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/closure_linter/closure_linter/testutil.py View 2 chunks +4 lines, -1 line 0 comments Download
M third_party/closure_linter/closure_linter/tokenutil.py View 4 chunks +21 lines, -17 lines 0 comments Download
M third_party/closure_linter/closure_linter/tokenutil_test.py View 2 chunks +10 lines, -2 lines 0 comments Download
A + third_party/closure_linter/closure_linter/trailing_comma_test.py View 3 chunks +23 lines, -27 lines 0 comments Download
A third_party/closure_linter/closure_linter/typeannotation.py View 1 chunk +410 lines, -0 lines 0 comments Download
A third_party/closure_linter/closure_linter/typeannotation_test.py View 1 chunk +233 lines, -0 lines 0 comments Download
M third_party/closure_linter/setup.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
The one and only Dr. Crash
4 years, 3 months ago (2016-09-08 18:48:59 UTC) #2
Dan Beam
lgtm https://codereview.chromium.org/2328693002/diff/1/third_party/closure_linter/closure_linter/fixjsstyle.py File third_party/closure_linter/closure_linter/fixjsstyle.py (right): https://codereview.chromium.org/2328693002/diff/1/third_party/closure_linter/closure_linter/fixjsstyle.py#newcode21 third_party/closure_linter/closure_linter/fixjsstyle.py:21: import StringIO this is probably fine
4 years, 3 months ago (2016-09-08 21:39:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2328693002/1
4 years, 3 months ago (2016-09-08 21:57:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-08 22:53:50 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 22:56:30 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/d61c8a2443b4fad17823e470c4fe3eea133b172e
Cr-Commit-Position: refs/heads/master@{#417426}

Powered by Google App Engine
This is Rietveld 408576698