Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: third_party/closure_linter/closure_linter/ecmametadatapass.py

Issue 2328693002: Updated linter with upstream release (2.3.19) (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_linter/closure_linter/ecmametadatapass.py
diff --git a/third_party/closure_linter/closure_linter/ecmametadatapass.py b/third_party/closure_linter/closure_linter/ecmametadatapass.py
index a8657d2f4defa91eaad2d071a94e16687f68f846..2036aa2824e64eaf32669a1d4a37a3f1ffb9c93e 100755
--- a/third_party/closure_linter/closure_linter/ecmametadatapass.py
+++ b/third_party/closure_linter/closure_linter/ecmametadatapass.py
@@ -495,17 +495,15 @@ class EcmaMetaDataPass(object):
is_implied_block = self._context == EcmaContext.IMPLIED_BLOCK
is_last_code_in_line = token.IsCode() and (
not next_code or next_code.line_number != token.line_number)
- is_continued_identifier = (token.type == TokenType.IDENTIFIER and
- token.string.endswith('.'))
is_continued_operator = (token.type == TokenType.OPERATOR and
not token.metadata.IsUnaryPostOperator())
is_continued_dot = token.string == '.'
next_code_is_operator = next_code and next_code.type == TokenType.OPERATOR
- next_code_is_dot = next_code and next_code.string == '.'
is_end_of_block = (
token.type == TokenType.END_BLOCK and
token.metadata.context.type != EcmaContext.OBJECT_LITERAL)
- is_multiline_string = token.type == TokenType.STRING_TEXT
+ is_multiline_string = (token.type == TokenType.STRING_TEXT or
+ token.type == TokenType.TEMPLATE_STRING_START)
is_continued_var_decl = (token.IsKeyword('var') and
next_code and
(next_code.type in [TokenType.IDENTIFIER,
@@ -517,10 +515,8 @@ class EcmaMetaDataPass(object):
not is_multiline_string and
not is_end_of_block and
not is_continued_var_decl and
- not is_continued_identifier and
not is_continued_operator and
not is_continued_dot and
- not next_code_is_dot and
not next_code_is_operator and
not is_implied_block and
not next_code_is_block):

Powered by Google App Engine
This is Rietveld 408576698