Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Unified Diff: third_party/closure_linter/closure_linter/requireprovidesorter.py

Issue 2328693002: Updated linter with upstream release (2.3.19) (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/closure_linter/closure_linter/requireprovidesorter.py
diff --git a/third_party/closure_linter/closure_linter/requireprovidesorter.py b/third_party/closure_linter/closure_linter/requireprovidesorter.py
index 8e2648013489e13e40f24da5c5ff03e5bb4ac8c9..e7e08a13c2946fff99aef8b273c0ae89eaf52a54 100755
--- a/third_party/closure_linter/closure_linter/requireprovidesorter.py
+++ b/third_party/closure_linter/closure_linter/requireprovidesorter.py
@@ -171,6 +171,9 @@ class RequireProvideSorter(object):
'goog.provide', 'goog.require', 'goog.setTestOnly']:
# These 3 identifiers are at the top of the file. So if any other
# identifier is encountered, return.
+ # TODO(user): Once it's decided what ordering goog.require
+ # should use, add 'goog.module' to the list above and implement the
+ # decision.
break
token = token.next

Powered by Google App Engine
This is Rietveld 408576698