Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp

Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types. (Closed)
Patch Set: Address imcheng@ comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
index 58eb02e387a4e8d50844474513aa3ce42c06d1be..ab095423d465fbafc3a6d076fa1abc8515d9b754 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
@@ -106,8 +106,8 @@ ScriptPromise PresentationRequest::start(ScriptState* scriptState)
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
// TODO(crbug.com/627655): Accept multiple URLs per PresentationRequest.
- WebVector<WebString> presentationUrls(static_cast<size_t>(1U));
- presentationUrls[0] = m_url.getString();
+ WebVector<WebURL> presentationUrls(static_cast<size_t>(1U));
+ presentationUrls[0] = m_url;
client->startSession(presentationUrls, new PresentationConnectionCallbacks(resolver, this));
return resolver->promise();
}
@@ -123,8 +123,8 @@ ScriptPromise PresentationRequest::reconnect(ScriptState* scriptState, const Str
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
// TODO(crbug.com/627655): Accept multiple URLs per PresentationRequest.
- WebVector<WebString> presentationUrls(static_cast<size_t>(1U));
- presentationUrls[0] = m_url.getString();
+ WebVector<WebURL> presentationUrls(static_cast<size_t>(1U));
+ presentationUrls[0] = m_url;
client->joinSession(presentationUrls, id, new PresentationConnectionCallbacks(resolver, this));
return resolver->promise();
}
@@ -139,7 +139,7 @@ ScriptPromise PresentationRequest::getAvailability(ScriptState* scriptState)
return ScriptPromise::rejectWithDOMException(scriptState, DOMException::create(InvalidStateError, "The PresentationRequest is no longer associated to a frame."));
ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState);
- client->getAvailability(m_url.getString(), new PresentationAvailabilityCallbacks(resolver, m_url));
+ client->getAvailability(m_url, new PresentationAvailabilityCallbacks(resolver, m_url));
return resolver->promise();
}

Powered by Google App Engine
This is Rietveld 408576698