third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp - Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types. (Closed)

Patch Set: Address imcheng@ comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/PresentationConnection.h ('k') | third_party/WebKit/Source/modules/presentation/PresentationController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

index 8149c1449ecf0bd8fc1e7bfd8f172c60f8604ff9..3f643022b97f7f1dd395c36ba8e4746b7748b5ce 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

@@ -157,7 +157,7 @@ private:

std::unique_ptr<FileReaderLoader> m_loader;

};

-PresentationConnection::PresentationConnection(LocalFrame* frame, const String& id, const String& url)

+PresentationConnection::PresentationConnection(LocalFrame* frame, const String& id, const KURL& url)

: DOMWindowProperty(frame)

, m_id(id)

, m_url(url)

@@ -406,7 +406,7 @@ void PresentationConnection::terminate()

bool PresentationConnection::matches(WebPresentationConnectionClient* client) const

{

- return client && m_url == static_cast<String>(client->getUrl()) && m_id == static_cast<String>(client->getId());

+ return client && m_url == KURL(client->getUrl()) && m_id == static_cast<String>(client->getId());

dcheng 2016/09/14 20:07:27 Can we tag WebPresentationConnectionClient::getUrl

}

void PresentationConnection::didChangeState(WebPresentationConnectionState state)