third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp - Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types. (Closed)

Patch Set: Address imcheng@ comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('K') | « third_party/WebKit/Source/modules/presentation/PresentationController.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp b/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

index d8f6e39197310d7fb9ff91298e9c1a207cf981ae..a41ce2bca7eb8790e7e7129342bfa2ee6982ae5f 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp

@@ -9,6 +9,7 @@

#include "core/frame/LocalFrame.h"

#include "core/testing/DummyPageHolder.h"

#include "modules/presentation/PresentationConnectionList.h"

+#include "platform/testing/URLTestHelpers.h"

#include "public/platform/modules/presentation/WebPresentationConnectionClient.h"

#include "testing/gmock/include/gmock/gmock.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -34,7 +35,7 @@ public:

class TestWebPresentationConnectionClient : public WebPresentationConnectionClient {

public:

WebString getId() override { return WebString::fromUTF8("id"); }

- WebString getUrl() override { return WebString::fromUTF8("url"); }

+ WebURL getUrl() override { return URLTestHelpers::toKURL("http://www.example.com"); }

};

class PresentationReceiverTest : public ::testing::Test {