third_party/WebKit/Source/modules/presentation/PresentationController.cpp - Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

Issue 2327993002: [PresentationAPI] Use KURL and WebURL in place of string types. (Closed)

Patch Set: Address imcheng@ comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('K') | « third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationReceiverTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationController.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

index c809d5fbe08165e93210f349302fa39e485c8f45..d0a63d72337a93d4c3d2c159395700a35583eb07 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationController.cpp

@@ -121,9 +121,9 @@ void PresentationController::setDefaultRequestUrl(const KURL& url)

return;

// TODO(crbug.com/627655): Accept multiple URLs per PresentationRequest.

- WebVector<WebString> presentationUrls(static_cast<size_t>(1));

+ WebVector<WebURL> presentationUrls(static_cast<size_t>(1));

if (url.isValid())

- presentationUrls[0] = url.getString();

+ presentationUrls[0] = url;

m_client->setDefaultPresentationUrls(presentationUrls);

}