[PresentationAPI] Use KURL and WebURL in place of string types.

Converts Presentation API to use KURL/WebURL in place of string types for availability and presentation URLs.  Removes several conversions.

BUG=632623
Committed: https://crrev.com/551008391f0723c846b2277048ef7ce9c61e805b
Cr-Commit-Position: refs/heads/master@{#418767}

[mark a. foltz, 2016-09-10 07:10:37]

Description was changed from

==========
[WIP] [PresentationAPI] Use KURL/WebURL in place of string types.

BUG=
==========

to

==========
Converts Presentation API to use KURL/WebURL in place of string types for
availability and presentation URLs.  Removes several conversions.

BUG=632623
==========

[mark a. foltz, 2016-09-10 07:10:38]

mfoltz@chromium.org changed reviewers:
+ imcheng@chromium.org

[mark a. foltz, 2016-09-10 07:13:25]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-10 07:13:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-10 08:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-10 08:27:08]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[mark a. foltz, 2016-09-12 17:00:07]

The CQ bit was checked by mfoltz@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-12 17:00:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 17:32:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 17:32:55]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[imcheng, 2016-09-14 00:39:14]

lgtm

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
File content/renderer/presentation/presentation_connection_client.cc (right):

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_connection_client.cc:15: :
url_(blink::WebURL(session_info->url)),
nit: can this url_(session_info->url) ?

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_connection_client.cc:21: :
url_(blink::WebURL(url)),
ditto

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
File content/renderer/presentation/presentation_dispatcher.cc (right):

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_dispatcher.cc:497: // 
session_info->url = GURL(presentationUrl.utf8());
rm this line

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_dispatcher.cc:519: // 
session_info->url = GURL(presentationUrl.utf8());
ditto

[mark a. foltz, 2016-09-14 20:02:42]

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
File content/renderer/presentation/presentation_connection_client.cc (right):

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_connection_client.cc:15: :
url_(blink::WebURL(session_info->url)),
On 2016/09/14 at 00:39:13, imcheng wrote:
> nit: can this url_(session_info->url) ?

Done.

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_connection_client.cc:21: :
url_(blink::WebURL(url)),
On 2016/09/14 at 00:39:13, imcheng wrote:
> ditto

Done.

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
File content/renderer/presentation/presentation_dispatcher.cc (right):

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_dispatcher.cc:497: // 
session_info->url = GURL(presentationUrl.utf8());
On 2016/09/14 at 00:39:13, imcheng wrote:
> rm this line

Done.

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_dispatcher.cc:497: // 
session_info->url = GURL(presentationUrl.utf8());
On 2016/09/14 at 00:39:13, imcheng wrote:
> rm this line

Done.

https://codereview.chromium.org/2327993002/diff/100001/content/renderer/prese...
content/renderer/presentation/presentation_dispatcher.cc:519: // 
session_info->url = GURL(presentationUrl.utf8());
On 2016/09/14 at 00:39:14, imcheng wrote:
> ditto

Done.

[mark a. foltz, 2016-09-14 20:02:47]

The CQ bit was checked by mfoltz@chromium.org

[mark a. foltz, 2016-09-14 20:02:48]

The patchset sent to the CQ was uploaded after l-g-t-m from imcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2327993002/#ps120001
(title: "Address imcheng@ comments")

[commit-bot: I haz the power, 2016-09-14 20:03:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dcheng, 2016-09-14 20:07:26]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-09-14 20:07:27]

LGTM

https://codereview.chromium.org/2327993002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
(right):

https://codereview.chromium.org/2327993002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp:409:
return client && m_url == KURL(client->getUrl()) && m_id ==
static_cast<String>(client->getId());
Can we tag WebPresentationConnectionClient::getUrl with a TODO to use WebURL as
well?

[mark a. foltz, 2016-09-14 20:11:33]

On 2016/09/14 at 20:07:27, dcheng wrote:
> LGTM
> 
>
https://codereview.chromium.org/2327993002/diff/120001/third_party/WebKit/Sou...
> File third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
(right):
> 
>
https://codereview.chromium.org/2327993002/diff/120001/third_party/WebKit/Sou...
> third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp:409:
return client && m_url == KURL(client->getUrl()) && m_id ==
static_cast<String>(client->getId());
> Can we tag WebPresentationConnectionClient::getUrl with a TODO to use WebURL
as well?

It should already...

[commit-bot: I haz the power, 2016-09-14 21:00:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 21:00:12]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mark a. foltz, 2016-09-15 01:43:16]

The CQ bit was checked by mfoltz@chromium.org

[commit-bot: I haz the power, 2016-09-15 01:43:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-15 02:49:13]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-09-15 02:51:11]

Description was changed from

==========
Converts Presentation API to use KURL/WebURL in place of string types for
availability and presentation URLs.  Removes several conversions.

BUG=632623
==========

to

==========
Converts Presentation API to use KURL/WebURL in place of string types for
availability and presentation URLs.  Removes several conversions.

BUG=632623

Committed: https://crrev.com/551008391f0723c846b2277048ef7ce9c61e805b
Cr-Commit-Position: refs/heads/master@{#418767}
==========

[commit-bot: I haz the power, 2016-09-15 02:51:12]

Patchset 7 (id:??) landed as
https://crrev.com/551008391f0723c846b2277048ef7ce9c61e805b
Cr-Commit-Position: refs/heads/master@{#418767}