Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 2327723002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Created:
4 years, 3 months ago by Devlin
Modified:
4 years, 3 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some ChromeSyncExtensionFunctions SyncExtensionFunctions, AsyncExtensionFunctions, ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are deprecated. Remove ChromeSyncExtensionFunctions from: - cookies - desktop_capture - downloads - module BUG=634140 Committed: https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4 Cr-Commit-Position: refs/heads/master@{#417656}

Patch Set 1 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -138 lines) Patch
M chrome/browser/extensions/api/cookies/cookies_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/cookies/cookies_api.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.h View 10 chunks +20 lines, -20 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 16 chunks +93 lines, -86 lines 0 comments Download
M chrome/browser/extensions/api/module/module.h View 5 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/module/module.cc View 1 chunk +14 lines, -13 lines 0 comments Download
M extensions/browser/extension_function.h View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/extension_function.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
Devlin
4 years, 3 months ago (2016-09-09 18:29:28 UTC) #16
lazyboy
lgtm
4 years, 3 months ago (2016-09-09 18:56:10 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2327723002/40001
4 years, 3 months ago (2016-09-09 19:02:39 UTC) #19
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 3 months ago (2016-09-09 19:07:52 UTC) #20
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 19:09:48 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f79e504bceef52d751cf28ed49c6de4a34fdeb4
Cr-Commit-Position: refs/heads/master@{#417656}

Powered by Google App Engine
This is Rietveld 408576698