chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc - Issue 2327723002: [Extensions] Convert some ChromeSyncExtensionFunctions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

Issue 2327723002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)

Patch Set: fix Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/desktop_capture/desktop_capture_base.h ('k') | chrome/browser/extensions/api/downloads/downloads_api.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

diff --git a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

index 8438d65f225932b3d0175bf708521e59ab499895..0aed483074e43ad85bbd0c92ac1b21dbb85a01e2 100644

--- a/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

+++ b/chrome/browser/extensions/api/desktop_capture/desktop_capture_base.cc

@@ -240,13 +240,14 @@ DesktopCaptureCancelChooseDesktopMediaFunctionBase::

DesktopCaptureCancelChooseDesktopMediaFunctionBase::

~DesktopCaptureCancelChooseDesktopMediaFunctionBase() {}

-bool DesktopCaptureCancelChooseDesktopMediaFunctionBase::RunSync() {

+ExtensionFunction::ResponseAction

+DesktopCaptureCancelChooseDesktopMediaFunctionBase::Run() {

int request_id;

EXTENSION_FUNCTION_VALIDATE(args_->GetInteger(0, &request_id));

DesktopCaptureRequestsRegistry::GetInstance()->CancelRequest(

render_frame_host()->GetProcess()->GetID(), request_id);

- return true;

+ return RespondNow(NoArguments());

}

DesktopCaptureRequestsRegistry::DesktopCaptureRequestsRegistry() {}