Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: extensions/browser/extension_function.h

Issue 2327723002: [Extensions] Convert some ChromeSyncExtensionFunctions (Closed)
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/api/module/module.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/extension_function.h
diff --git a/extensions/browser/extension_function.h b/extensions/browser/extension_function.h
index c62e1f77846b30e94835d9a3510ac0e9939259d4..40ac407ca5d4a40ed7205e519117c81874a8a5c8 100644
--- a/extensions/browser/extension_function.h
+++ b/extensions/browser/extension_function.h
@@ -168,6 +168,13 @@ class ExtensionFunction
~ScopedUserGestureForTests();
};
+ // A string used in the case of an unknown error being detected.
+ // DON'T USE THIS. It's only here during conversion to flag cases where errors
+ // aren't already set.
+ // TODO(devlin): Remove this if/when all functions are updated to return real
+ // errors.
+ static const char* kUnknownErrorDoNotUse;
+
// Called before Run() in order to perform a common verification check so that
// APIs subclassing this don't have to roll their own RunSafe() variants.
// If this returns false, then Run() is never called, and the function
« no previous file with comments | « chrome/browser/extensions/api/module/module.cc ('k') | extensions/browser/extension_function.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698