[builtins] Migrate ToNumber to TurboFan.

[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
Committed: https://crrev.com/278b9f800b67126b096e6ed03942b0597b2ad3b8
Cr-Commit-Position: refs/heads/master@{#39343}

[alegil02, 2016-09-09 08:15:36]

Description was changed from

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
==========

to

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
==========

[alegil02, 2016-09-09 08:15:36]

alexander.gilday2@arm.com changed reviewers:
+ bmeurer@chromium.org, ishell@chromium.org, rmcilroy@chromium.org

[rmcilroy, 2016-09-09 11:03:18]

interpreter LGTM other than same nits made for the ToName CL.

https://codereview.chromium.org/2327703003/diff/1/src/interpreter/interpreter.cc
File src/interpreter/interpreter.cc (right):

https://codereview.chromium.org/2327703003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:1315: Node* accumulator = __ GetAccumulator();
/s/accumulator/object

https://codereview.chromium.org/2327703003/diff/1/src/interpreter/interpreter...
src/interpreter/interpreter.cc:1317: Node* result = assembler->ToNumber(context,
accumulator);
/s/assembler->/__

[rmcilroy, 2016-09-09 11:03:53]

Didn't look at the rest of the CL though, please make sure Benedikt or Igor look
through the rest.

[alegil02, 2016-09-09 11:07:11]

On 2016/09/09 11:03:53, rmcilroy wrote:
> Didn't look at the rest of the CL though, please make sure Benedikt or Igor
look
> through the rest.

Thanks, I did notice the same nits and have them fixed on my machine currently
but waiting for more nits (or lgtm) before further review.

[Igor Sheludko, 2016-09-09 11:33:15]

lgtm with nits:

https://codereview.chromium.org/2327703003/diff/1/src/builtins/builtins-conve...
File src/builtins/builtins-conversion.cc (right):

https://codereview.chromium.org/2327703003/diff/1/src/builtins/builtins-conve...
src/builtins/builtins-conversion.cc:122: // ES6 section 7.1.3 ToNumber (
argument )
// static
or remove it.

https://codereview.chromium.org/2327703003/diff/1/src/builtins/builtins-conve...
src/builtins/builtins-conversion.cc:133: // static
// ES6 section 7.1.3 ToNumber ( argument )

https://codereview.chromium.org/2327703003/diff/1/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2327703003/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2367: Word32NotEqual(LoadInstanceType(input),
Int32Constant(HEAP_NUMBER_TYPE)));
How about doing a map check here?

https://codereview.chromium.org/2327703003/diff/1/src/code-stub-assembler.cc#...
src/code-stub-assembler.cc:2470: GotoIf(Word32NotEqual(input_instance_type,
Int32Constant(HEAP_NUMBER_TYPE)),
While we are here, how about doing a map check instead?

[alegil02, 2016-09-09 16:13:46]

The CQ bit was checked by alexander.gilday2@arm.com

[alegil02, 2016-09-09 16:13:46]

The patchset sent to the CQ was uploaded after l-g-t-m from ishell@chromium.org,
rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2327703003/#ps20001
(title: "Addressed nits.")

[commit-bot: I haz the power, 2016-09-09 16:13:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 16:18:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 16:18:04]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23715)

[alegil02, 2016-09-12 09:18:11]

alexander.gilday2@arm.com changed reviewers:
+ mstarzinger@chromium.org
- Alexander.Gilday2@arm.com

[alegil02, 2016-09-12 09:19:21]

On 2016/09/09 16:18:04, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_presubmit on master.tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23715)

Added an owner for code-assembler.h, PTAL that part.

[Benedikt Meurer, 2016-09-12 09:50:31]

LGTM on CodeAssembler.

[Benedikt Meurer, 2016-09-12 09:50:41]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2016-09-12 09:50:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 09:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 09:52:20]

Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

[alegil02, 2016-09-12 09:58:51]

On 2016/09/12 09:52:20, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
>   v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
>   v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)

Seems like a rebasing issue, with a merge conflict from my ToName patch. Fixing
now.

[alegil02, 2016-09-12 10:32:29]

The CQ bit was checked by alexander.gilday2@arm.com

[alegil02, 2016-09-12 10:32:30]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, ishell@chromium.org, rmcilroy@chromium.org
Link to the patchset: https://codereview.chromium.org/2327703003/#ps40001
(title: "Rebase")

[commit-bot: I haz the power, 2016-09-12 10:32:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 11:00:43]

Description was changed from

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
==========

to

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
==========

[commit-bot: I haz the power, 2016-09-12 11:00:45]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-12 11:01:19]

Description was changed from

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049
==========

to

==========
[builtins] Migrate ToNumber to TurboFan.

Migrate ToNumber platform builtin to TurboFan. Also move
NonNumberToNumber builtin implementation to helper function.

BUG=v8:5049

Committed: https://crrev.com/278b9f800b67126b096e6ed03942b0597b2ad3b8
Cr-Commit-Position: refs/heads/master@{#39343}
==========

[commit-bot: I haz the power, 2016-09-12 11:01:20]

Patchset 3 (id:??) landed as
https://crrev.com/278b9f800b67126b096e6ed03942b0597b2ad3b8
Cr-Commit-Position: refs/heads/master@{#39343}