Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: device/generic_sensor/sensor_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/battery/battery_monitor_impl.cc ('k') | device/generic_sensor/sensor_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/generic_sensor/sensor_impl.h
diff --git a/device/generic_sensor/sensor_impl.h b/device/generic_sensor/sensor_impl.h
index ea501236014d5761f943fc1d82f25f3cacdf1013..3730fc688706ea0fcdedba1ea1dfaf4846502049 100644
--- a/device/generic_sensor/sensor_impl.h
+++ b/device/generic_sensor/sensor_impl.h
@@ -8,7 +8,6 @@
#include "base/macros.h"
#include "device/generic_sensor/platform_sensor.h"
#include "device/generic_sensor/public/interfaces/sensor.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
@@ -16,8 +15,7 @@ namespace device {
// Instances of this class are created by SensorProviderImpl.
class SensorImpl final : public mojom::Sensor, public PlatformSensor::Client {
public:
- SensorImpl(mojo::InterfaceRequest<mojom::Sensor> request,
- scoped_refptr<PlatformSensor> sensor);
+ explicit SensorImpl(scoped_refptr<PlatformSensor> sensor);
~SensorImpl() override;
mojom::SensorClientRequest GetClient();
@@ -41,9 +39,9 @@ class SensorImpl final : public mojom::Sensor, public PlatformSensor::Client {
private:
scoped_refptr<PlatformSensor> sensor_;
- mojo::StrongBinding<Sensor> binding_;
mojom::SensorClientPtr client_;
bool suspended_;
+
DISALLOW_COPY_AND_ASSIGN(SensorImpl);
};
« no previous file with comments | « device/battery/battery_monitor_impl.cc ('k') | device/generic_sensor/sensor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698