Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Side by Side Diff: device/generic_sensor/sensor_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/battery/battery_monitor_impl.cc ('k') | device/generic_sensor/sensor_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_ 5 #ifndef DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_
6 #define DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_ 6 #define DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "device/generic_sensor/platform_sensor.h" 9 #include "device/generic_sensor/platform_sensor.h"
10 #include "device/generic_sensor/public/interfaces/sensor.mojom.h" 10 #include "device/generic_sensor/public/interfaces/sensor.mojom.h"
11 #include "mojo/public/cpp/bindings/strong_binding.h"
12 11
13 namespace device { 12 namespace device {
14 13
15 // Implementation of Sensor mojo interface. 14 // Implementation of Sensor mojo interface.
16 // Instances of this class are created by SensorProviderImpl. 15 // Instances of this class are created by SensorProviderImpl.
17 class SensorImpl final : public mojom::Sensor, public PlatformSensor::Client { 16 class SensorImpl final : public mojom::Sensor, public PlatformSensor::Client {
18 public: 17 public:
19 SensorImpl(mojo::InterfaceRequest<mojom::Sensor> request, 18 explicit SensorImpl(scoped_refptr<PlatformSensor> sensor);
20 scoped_refptr<PlatformSensor> sensor);
21 ~SensorImpl() override; 19 ~SensorImpl() override;
22 20
23 mojom::SensorClientRequest GetClient(); 21 mojom::SensorClientRequest GetClient();
24 22
25 private: 23 private:
26 // Sensor implementation. 24 // Sensor implementation.
27 void AddConfiguration(const PlatformSensorConfiguration& configuration, 25 void AddConfiguration(const PlatformSensorConfiguration& configuration,
28 const AddConfigurationCallback& callback) override; 26 const AddConfigurationCallback& callback) override;
29 void GetDefaultConfiguration( 27 void GetDefaultConfiguration(
30 const GetDefaultConfigurationCallback& callback) override; 28 const GetDefaultConfigurationCallback& callback) override;
31 void RemoveConfiguration( 29 void RemoveConfiguration(
32 const PlatformSensorConfiguration& configuration, 30 const PlatformSensorConfiguration& configuration,
33 const RemoveConfigurationCallback& callback) override; 31 const RemoveConfigurationCallback& callback) override;
34 void Suspend() override; 32 void Suspend() override;
35 void Resume() override; 33 void Resume() override;
36 34
37 // device::Sensor::Client implementation. 35 // device::Sensor::Client implementation.
38 void OnSensorReadingChanged() override; 36 void OnSensorReadingChanged() override;
39 void OnSensorError() override; 37 void OnSensorError() override;
40 bool IsNotificationSuspended() override; 38 bool IsNotificationSuspended() override;
41 39
42 private: 40 private:
43 scoped_refptr<PlatformSensor> sensor_; 41 scoped_refptr<PlatformSensor> sensor_;
44 mojo::StrongBinding<Sensor> binding_;
45 mojom::SensorClientPtr client_; 42 mojom::SensorClientPtr client_;
46 bool suspended_; 43 bool suspended_;
44
47 DISALLOW_COPY_AND_ASSIGN(SensorImpl); 45 DISALLOW_COPY_AND_ASSIGN(SensorImpl);
48 }; 46 };
49 47
50 } // namespace device 48 } // namespace device
51 49
52 #endif // DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_ 50 #endif // DEVICE_GENERIC_SENSOR_SENSOR_IMPL_H_
OLDNEW
« no previous file with comments | « device/battery/battery_monitor_impl.cc ('k') | device/generic_sensor/sensor_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698