Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2584)

Unified Diff: device/battery/battery_monitor_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/battery/battery_monitor_impl.h ('k') | device/generic_sensor/sensor_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/battery/battery_monitor_impl.cc
diff --git a/device/battery/battery_monitor_impl.cc b/device/battery/battery_monitor_impl.cc
index 7a77c5b14da716fc0763286290a568e3f619f4f2..e27f043bf5a0afbc9640aeadd77d22ebd63d4081 100644
--- a/device/battery/battery_monitor_impl.cc
+++ b/device/battery/battery_monitor_impl.cc
@@ -8,18 +8,17 @@
#include "base/bind.h"
#include "base/logging.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace device {
// static
-void BatteryMonitorImpl::Create(
- mojo::InterfaceRequest<BatteryMonitor> request) {
- new BatteryMonitorImpl(std::move(request));
+void BatteryMonitorImpl::Create(BatteryMonitorRequest request) {
+ mojo::MakeStrongBinding(base::MakeUnique<BatteryMonitorImpl>(),
+ std::move(request));
}
-BatteryMonitorImpl::BatteryMonitorImpl(
- mojo::InterfaceRequest<BatteryMonitor> request)
- : binding_(this, std::move(request)), status_to_report_(false) {
+BatteryMonitorImpl::BatteryMonitorImpl() : status_to_report_(false) {
// NOTE: DidChange may be called before AddCallback returns. This is done to
// report current status.
subscription_ = BatteryStatusService::GetInstance()->AddCallback(
« no previous file with comments | « device/battery/battery_monitor_impl.h ('k') | device/generic_sensor/sensor_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698