Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: content/browser/media/android/provision_fetcher_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/provision_fetcher_impl.h
diff --git a/content/browser/media/android/provision_fetcher_impl.h b/content/browser/media/android/provision_fetcher_impl.h
index dcbf1aed90e5723eebbedb1ba343eded5a520983..fc1955742eb2e6a0da92df36425916eb66c4710e 100644
--- a/content/browser/media/android/provision_fetcher_impl.h
+++ b/content/browser/media/android/provision_fetcher_impl.h
@@ -12,7 +12,6 @@
#include "content/public/browser/android/provision_fetcher_factory.h"
#include "media/base/android/provision_fetcher.h"
#include "media/mojo/interfaces/provision_fetcher.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace content {
@@ -22,13 +21,11 @@ class RenderFrameHost;
// media::ProvisionFetcher.
class ProvisionFetcherImpl : public media::mojom::ProvisionFetcher {
public:
- static void Create(
- RenderFrameHost* render_frame_host,
- mojo::InterfaceRequest<media::mojom::ProvisionFetcher> request);
+ static void Create(RenderFrameHost* render_frame_host,
+ media::mojom::ProvisionFetcherRequest request);
- ProvisionFetcherImpl(
- std::unique_ptr<media::ProvisionFetcher> provision_fetcher,
- mojo::InterfaceRequest<ProvisionFetcher> request);
+ explicit ProvisionFetcherImpl(
+ std::unique_ptr<media::ProvisionFetcher> provision_fetcher);
~ProvisionFetcherImpl() override;
// media::mojom::ProvisionFetcher implementation.
@@ -42,7 +39,6 @@ class ProvisionFetcherImpl : public media::mojom::ProvisionFetcher {
bool success,
const std::string& response);
- mojo::StrongBinding<media::mojom::ProvisionFetcher> binding_;
std::unique_ptr<media::ProvisionFetcher> provision_fetcher_;
base::WeakPtrFactory<ProvisionFetcherImpl> weak_factory_;
« no previous file with comments | « content/browser/loader/url_loader_factory_impl.cc ('k') | content/browser/media/android/provision_fetcher_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698