Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Unified Diff: content/browser/loader/url_loader_factory_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/url_loader_factory_impl.cc
diff --git a/content/browser/loader/url_loader_factory_impl.cc b/content/browser/loader/url_loader_factory_impl.cc
index 2f02691c88816520504ff363a035a7c91b451add..d232f5cfe4452899ab60be5e508802a3f6aba46e 100644
--- a/content/browser/loader/url_loader_factory_impl.cc
+++ b/content/browser/loader/url_loader_factory_impl.cc
@@ -9,14 +9,13 @@
#include "content/common/resource_request.h"
#include "content/common/url_loader.mojom.h"
#include "content/public/browser/browser_thread.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace content {
URLLoaderFactoryImpl::URLLoaderFactoryImpl(
- scoped_refptr<ResourceMessageFilter> resource_message_filter,
- mojo::InterfaceRequest<mojom::URLLoaderFactory> request)
- : resource_message_filter_(std::move(resource_message_filter)),
- binding_(this, std::move(request)) {
+ scoped_refptr<ResourceMessageFilter> resource_message_filter)
+ : resource_message_filter_(std::move(resource_message_filter)) {
DCHECK(resource_message_filter_);
DCHECK_CURRENTLY_ON(BrowserThread::IO);
}
@@ -43,8 +42,9 @@ void URLLoaderFactoryImpl::CreateLoaderAndStart(
void URLLoaderFactoryImpl::Create(
scoped_refptr<ResourceMessageFilter> filter,
mojo::InterfaceRequest<mojom::URLLoaderFactory> request) {
- // The created instance is held by the StrongBinding.
- new URLLoaderFactoryImpl(std::move(filter), std::move(request));
+ mojo::MakeStrongBinding(
+ base::WrapUnique(new URLLoaderFactoryImpl(std::move(filter))),
+ std::move(request));
}
} // namespace content
« no previous file with comments | « content/browser/loader/url_loader_factory_impl.h ('k') | content/browser/media/android/provision_fetcher_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698